feat: Ability to disable log collection at the tracer level #1254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanojsubran
requested changes
Sep 17, 2025
There was a problem hiding this comment.
@Angith I have done one round of review. Kindly check my comments. We can discuss together.
sanojsubran
requested changes
Sep 24, 2025
There was a problem hiding this comment.
@Angith The changes look good. I have added few suggestions. Kindly check.
Co-authored-by: Sanoj Subran <sanoj.subran@ibm.com>
Co-authored-by: Sanoj Subran <sanoj.subran@ibm.com>
nithinputhenveettil
requested changes
Sep 26, 2025
Co-authored-by: Nithin Puthenveettil <nithin.puthenveettil@ibm.com>
Co-authored-by: Nithin Puthenveettil <nithin.puthenveettil@ibm.com>
Co-authored-by: Nithin Puthenveettil <nithin.puthenveettil@ibm.com>
sanojsubran
reviewed
Sep 26, 2025
Co-authored-by: Sanoj Subran <sanoj.subran@ibm.com>
sanojsubran
reviewed
Sep 29, 2025
sanojsubran
reviewed
Sep 29, 2025
Angith
force-pushed
the
disabling-log-spans
branch
from
e242207 to
bfbee64
Compare
sanojsubran
reviewed
Sep 29, 2025
sanojsubran
reviewed
Sep 29, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables Go Tracer to disable log spans at tracer level.
There are four ways to disable log spans: