add new mode argument

[BFalquet]

Add a mode argument to log_filter to make the function more flexible.

• document
• add test
• minor modification of reformatting documentation (see Documentation unclear for reformats #181)

thank you for the review

[github-actions]

Code Coverage Summary

Filename                  Stmts    Miss  Cover    Missing
----------------------  -------  ------  -------  ---------
R/assertions.R               73       0  100.00%
R/co_relevels.R              17       0  100.00%
R/cut_by_group.R             15       0  100.00%
R/explicit_na.R              26       0  100.00%
R/filter.R                   79       0  100.00%
R/join_adsub_adsl.R          92       8  91.30%   166-173
R/pivot.R                    59       0  100.00%
R/propagate.R                22       0  100.00%
R/reformat.R                 91       0  100.00%
R/render_safe.R              55       1  98.18%   50
R/rules.R                    72       0  100.00%
R/subject_level_flag.R       44       0  100.00%
R/unite.R                    31       0  100.00%
R/utils.R                    21       2  90.48%   72-73
R/zzz.R                       3       3  0.00%    4-6
TOTAL                       700      14  98.00%

Diff against main

Filename                  Stmts    Miss  Cover
----------------------  -------  ------  --------
R/assertions.R              +19       0  +100.00%
R/filter.R                   +6       0  +100.00%
R/join_adsub_adsl.R         +26       0  +3.43%
R/pivot.R                   -14       0  +100.00%
R/reformat.R                +36       0  +100.00%
R/render_safe.R             +17       0  +0.81%
R/rules.R                   +19      -1  +1.89%
R/subject_level_flag.R      +44       0  +100.00%
R/utils.R                    -6      +2  -9.52%
TOTAL                      +147      +1  +0.35%

Results for commit: 37d96e5

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

  1 files   14 suites   2s ⏱️
111 tests 108 ✅ 3 💤 0 ❌
370 runs  365 ✅ 5 💤 0 ❌

Results for commit 37d96e5.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
filter	👶		$+0.03$	log_filter_works_with_custom_mode_argument

Results for commit 4c5834a

♻️ This comment has been updated with latest results.

[Copilot]

Pull Request Overview

Introduce a new mode argument to log_filter to control whether related tables are also filtered, plus documentation updates and tests.

• Add mode parameter to log_filter.list with values "all" or "unique"
• Update documentation for log_filter and reformat; add tests for new behavior
• Bump RoxygenNote

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
R/filter.R	Implements mode in log_filter.list, adds argument validation, and generalizes cross-table filtering beyond adsl
tests/testthat/test-filter.R	Adds tests for mode = "all" and mode = "unique" behavior
man/log_filter.Rd	Documents new mode parameter and updates details
R/reformat.R	Expands function description/comments for reformat
man/reformat.Rd	Updates description and adds vignette reference
man/get_arg.Rd	Simplifies example preamble in dontshow block
NEWS.md	Notes new mode feature
DESCRIPTION	Updates RoxygenNote

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Melkiades]

maybe you could show the attribute that was filtered out/in?

[Melkiades]

should this be adsl as default maybe?

[Melkiades]

Suggested change

	#' @param ... further arguments to be passed to or from other methods.
	#' @returns a `data.frame` or `list` of `data.frame` filtered for the provided conditions.
	#' @details
	#' @param ... further arguments to be passed to or from other methods.
	#'
	#' @returns a `data.frame` or `list` of `data.frame` filtered for the provided conditions.
	#'
	#' @details

[Melkiades]

Suggested change

	#' in table (using by), or `mode = "unique"` to leave other tables unchanged.
	#' @export
	#' in table (using by), or `mode = "unique"` to leave other tables unchanged.
	#'
	#' @export

[Melkiades]

just for readability

[Melkiades]

Lgtm! Just few minors. Thanks Benoit