feat: make graph constructors default to undirected for consistency #2453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graph constructors were inconsistent - some defaulted to directed (
make_tree,make_star,make_graph) while most defaulted to undirected (sample_gnm,make_ring,make_full_graph). This creates unnecessary confusion.Changes
make_tree(): Now defaults tomode = "undirected"(was"out")make_star(): Now defaults tomode = "undirected"(was"in")make_graph(): Now defaults todirected = FALSE(wasTRUE)make_graph()ignored its defaultdirectedparameter when using numeric edge vectorsgraph(),graph.tree(),graph.star()) to matchBefore/After
Breaking Change
This is a breaking change for v2.0. Code relying on implicit directed defaults must be updated to explicitly specify
directed = TRUEormode = "in"/"out".Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.