Replace interp2d with RectBivariateSpline #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvansanten
force-pushed
the
remove-interp2d
branch
3 times, most recently
from
2172ffa to
58b7712
Compare
interp2d is gone in scipy 1.14, and RecBivariateSpline is 5x faster to evaluate. While the numerical results are identical, RectBivariateSpline returns a 2D array for scalar inputs, whereas interp2d returned a 1D array. Work around this by removing all 1-entry dimensions from the result. A notable exception is the acceptance in StandardLLH, which appears to have relied on the result being 1D (i.e. tests fail if the interpolation returns a scalar). Fixes icecube#270
jvansanten
force-pushed
the
remove-interp2d
branch
from
58b7712 to
11b8d2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
interp2d is gone in scipy 1.14, and RectBivariateSpline is 5x faster to evaluate
While the numerical results are identical, RectBivariateSpline
returns a 2D array for scalar inputs, whereas interp2d returned a
1D array. Work around this by removing all 1-entry dimensions from
the result. A notable exception is the acceptance in StandardLLH,
which appears to have relied on the result being 1D (i.e. tests
fail if the interpolation returns a scalar).
Fixes #270