Bugfix: Resolved question rewriting pipeline issues #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Question Rewriting Pipeline Issues
Relates to #178
1. Type Error in inference calls
After the fix I ran the question_rewriting pipeline and found other issues.
2. Missing required field validation
question_mode
is not part of theto_dict()
arguments (we don't save it as part of the dataset). So it triggers a validation error when building QuestionRow with the question_rewriting pipeline. The fix is to use a default value to pass validation. Thequestion_mode
is anyway not saved in the new_questions_rewritten
subset3. Missing subset error
multi_hop_questions
subset doesn't existResult
Question Rewriting pipeline should now work again.
Please test and let me know if I missed something or if I should follow a different approach to fix this.