Skip to content

Conversation

ParthShikhare19
Copy link

Description:
Improve the commit signing guide in [signing.md] for better usability and clarity, especially for first-time contributors.

Add table of contents to [signing.md]
Replace "Why Commit Signing?" section with expanded "Achieving Verified Commits" section
Emphasize requirement for both -s and -S flags in commits
Add "Additional Resources" section linking to other documentation
Related issue(s):

Fixes #455

Notes for reviewer:
This update enhances the documentation to make it easier for new contributors to understand and achieve verified commits, reducing barriers to PR submission.

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: ParthShikhare19 <parthshikhare21@gmail.com>
@ParthShikhare19 ParthShikhare19 changed the title signing.md file is updated and table of contents and critical issues … docs(signing): add table of contents and expand verified commits section Oct 20, 2025
Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent PR, final tidy up please and we are ready to go

@exploreriii
Copy link
Contributor

One more thing. Your commits must be verified! They are not
https://github.com/hiero-ledger/hiero-sdk-python/pull/462/commits

@ParthShikhare19
Copy link
Author

Then what can I do ?

@exploreriii
Copy link
Contributor

Read this section please Achieving Verified Commits

Essentially, git commit -S -s -m "chore: your message"
for each commit
you need a GPG key set up

@ParthShikhare19
Copy link
Author

ParthShikhare19 commented Oct 21, 2025

{8636A55D-A193-467F-82DA-BE2877D97863} @exploreriii I passed all cases still it shows merging is blocked

@exploreriii
Copy link
Contributor

Merging is blocked, your commits must achieve verified status and they are not. See here, there is no green label to it.
https://github.com/hiero-ledger/hiero-sdk-python/pull/462/commits
You can see the status verification of your commits by doing git log --pretty="%h %G? %aN %s"
Suggest to soft revert your commit and re-commit with -S and -s as described in signing.md

@ParthShikhare19
Copy link
Author

I added GPG key and I verify each and every commit still this happen
can you do somthing from your side to solve this problem??

@exploreriii
Copy link
Contributor

did you do
git commit -s -S -m "chore: your commit message" to each commit
additionally, push your changes if they are now signed
signing.md informs you how to do it

@ParthShikhare19
Copy link
Author

Yes I have done that already

@exploreriii
Copy link
Contributor

You need to push your changes, right now your only commit was yesterday
https://github.com/hiero-ledger/hiero-sdk-python/pull/462/commits

@exploreriii
Copy link
Contributor

Hi @ParthShikhare19 if you are still stuck on this, please contact me on discord and I will be happy to help

@exploreriii
Copy link
Contributor

Hi @ParthShikhare19 while I can solve your conflict with the changelog, I cannot verify the commits for you and this is a requirement. Please read signing.md to achieve verified commits and please get in touch!

If you instead choose not to progress with this issue, can I take on your changes and submit it myself? I will have to change the signing though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Warning Section and Table of Contents to docs/sdk_developers/signing.md

2 participants