-
Notifications
You must be signed in to change notification settings - Fork 72
docs(signing): add table of contents and expand verified commits section #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c42b621 to
7277764
Compare
Signed-off-by: ParthShikhare19 <parthshikhare21@gmail.com>
7277764 to
475c666
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent PR, final tidy up please and we are ready to go
|
One more thing. Your commits must be verified! They are not |
|
Then what can I do ? |
|
Read this section please Achieving Verified Commits Essentially, git commit -S -s -m "chore: your message" |
590d679 to
475c666
Compare
@exploreriii
I passed all cases still it shows merging is blocked
|
|
Merging is blocked, your commits must achieve verified status and they are not. See here, there is no green label to it. |
|
I added GPG key and I verify each and every commit still this happen |
|
did you do |
|
Yes I have done that already |
|
You need to push your changes, right now your only commit was yesterday |
|
Hi @ParthShikhare19 if you are still stuck on this, please contact me on discord and I will be happy to help |
|
Hi @ParthShikhare19 while I can solve your conflict with the changelog, I cannot verify the commits for you and this is a requirement. Please read signing.md to achieve verified commits and please get in touch! If you instead choose not to progress with this issue, can I take on your changes and submit it myself? I will have to change the signing though. |

Description:
Improve the commit signing guide in [signing.md] for better usability and clarity, especially for first-time contributors.
Add table of contents to [signing.md]
Replace "Why Commit Signing?" section with expanded "Achieving Verified Commits" section
Emphasize requirement for both -s and -S flags in commits
Add "Additional Resources" section linking to other documentation
Related issue(s):
Fixes #455
Notes for reviewer:
This update enhances the documentation to make it easier for new contributors to understand and achieve verified commits, reducing barriers to PR submission.
Checklist
Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)