-
Notifications
You must be signed in to change notification settings - Fork 72
feat: make network configurable via NETWORK environment variable #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make network configurable via NETWORK environment variable #384
Conversation
|
@exploreriii @nadineloepfe pls review and check |
I have updated all instances in the examples. Pls check @exploreriii |
|
@exploreriii any more changes needed?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Mounil
|
Thank you @Mounil2005! However, how about this in the examples:
? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Mounil2005 is the requested change clear? Let us know if you need any clarifications
Hello maam, hope you are doing well, the changes are clear but actually i didnt work on them cause currently my Uni exams are going on back-to-back…I request you to pls give me time till this weekend. I will work on it. |
|
No problem, thank you for the update |
Thank you for understanding ma'am. |
Thanks for the feedback! |
|
Thanks, also please note we have a new update 0.1.5 so the changelog, this would need to be added under unreleased above it |
Signed-off-by: Mounil <mounilkankhara@gmail.com>
…net if not set Signed-off-by: Mounil <mounilkankhara@gmail.com>
…ead of hardcoded 'testnet' Signed-off-by: Mounil <mounilkankhara@gmail.com>
a8689ff to
8c8297a
Compare
|
Hi Mounil, let me know when this is ready to review - thank you |
yes maam, i will surely let u know |
|
Hi @Mounil2005 |
|
Hi @Mounil2005 closing this issue down as coincidentally another PR that is nearly ready to merge solves this issue. |
Description:
Make Hedera network selection configurable via the NETWORK environment variable instead of hardcoding "testnet".
This improves flexibility for developers running on mainnet, previewnet, or solo.
Related issue(s):
Fixes #253
Checklist