-
Notifications
You must be signed in to change notification settings - Fork 133
Rest-java k6 tests in CI #12243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Rest-java k6 tests in CI #12243
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
3c0711b to
9ac5ea2
Compare
| log.info("Skipping cleanup of topic at address {}.", topicId); | ||
| // Log the values so that they can be parsed in CI and passed to the k6 tests as input. | ||
| System.out.println("DEFAULT_TOPIC=" + topicId.num); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we log both via logger and system.out? Should be one or the other.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logger is now removed.
.github/workflows/acceptance.yaml
Outdated
| DEFAULT_DURATION: "3s" | ||
| DEFAULT_GRACEFUL_STOP: "1s" | ||
| DEFAULT_VUS: 2 | ||
| RESTJAVA_TEST_EXCLUDE: "^(accounts(NftAllowanceOwner|NftAllowanceSpender|OutstandingAirdrop|PendingAirdrop))|rampUp.*$" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there not an acceptance test that adds these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are, but also there are steps that delete the allowances at the end or claim the airdrops, so after the execution of the acceptance tests they are no longer available. I will see what I can do without adding a bunch of new tests just to do the k6 setup.
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
1b7ab20 to
c097a95
Compare
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
c097a95 to
0ffb587
Compare
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
3f4e630 to
b48be24
Compare
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
b48be24 to
84776ef
Compare
c8acc6b to
8b149d5
Compare
Description:
Add rest-java k6 tests execution as part of the workflow in order to verify the end-to-end functionality. This will be helpful to catch some issues earlier in the testing cycle. The goal is not a complete coverage of all rest-java k6 tests, so the failing ones are excluded for now.
Fixes #12161