Skip to content

Conversation

@bilyana-gospodinova
Copy link
Contributor

@bilyana-gospodinova bilyana-gospodinova commented Oct 21, 2025

Description:
Add rest-java k6 tests execution as part of the workflow in order to verify the end-to-end functionality. This will be helpful to catch some issues earlier in the testing cycle. The goal is not a complete coverage of all rest-java k6 tests, so the failing ones are excluded for now.

Fixes #12161

@bilyana-gospodinova bilyana-gospodinova self-assigned this Oct 21, 2025
@bilyana-gospodinova bilyana-gospodinova added enhancement Type: New feature test Test infrastructure, automated tests required, etc github actions Pull requests that update GitHub Actions code labels Oct 21, 2025
@lfdt-bot
Copy link

lfdt-bot commented Oct 21, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codacy-production
Copy link

codacy-production bot commented Oct 21, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-31.86% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (290d15f) 37155 33839 91.08%
Head commit (8b149d5) 61891 (+24736) 36649 (+2810) 59.22% (-31.86%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#12243) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@bilyana-gospodinova bilyana-gospodinova force-pushed the 12161-k6-tests-in-ci-rest-java branch from 3c0711b to 9ac5ea2 Compare October 21, 2025 11:31
@bilyana-gospodinova bilyana-gospodinova marked this pull request as ready for review October 21, 2025 13:51
@bilyana-gospodinova bilyana-gospodinova requested review from a team as code owners October 21, 2025 13:51
@steven-sheehy steven-sheehy added this to the 0.142.0 milestone Oct 21, 2025
Comment on lines 58 to 60
log.info("Skipping cleanup of topic at address {}.", topicId);
// Log the values so that they can be parsed in CI and passed to the k6 tests as input.
System.out.println("DEFAULT_TOPIC=" + topicId.num);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we log both via logger and system.out? Should be one or the other.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logger is now removed.

DEFAULT_DURATION: "3s"
DEFAULT_GRACEFUL_STOP: "1s"
DEFAULT_VUS: 2
RESTJAVA_TEST_EXCLUDE: "^(accounts(NftAllowanceOwner|NftAllowanceSpender|OutstandingAirdrop|PendingAirdrop))|rampUp.*$"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there not an acceptance test that adds these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are, but also there are steps that delete the allowances at the end or claim the airdrops, so after the execution of the acceptance tests they are no longer available. I will see what I can do without adding a bunch of new tests just to do the k6 setup.

@bilyana-gospodinova bilyana-gospodinova marked this pull request as draft October 22, 2025 13:52
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova bilyana-gospodinova force-pushed the 12161-k6-tests-in-ci-rest-java branch from 1b7ab20 to c097a95 Compare October 23, 2025 12:44
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova bilyana-gospodinova force-pushed the 12161-k6-tests-in-ci-rest-java branch from c097a95 to 0ffb587 Compare October 23, 2025 12:48
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova bilyana-gospodinova force-pushed the 12161-k6-tests-in-ci-rest-java branch from 3f4e630 to b48be24 Compare October 24, 2025 13:58
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova bilyana-gospodinova force-pushed the 12161-k6-tests-in-ci-rest-java branch from b48be24 to 84776ef Compare October 24, 2025 14:25
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova bilyana-gospodinova force-pushed the 12161-k6-tests-in-ci-rest-java branch from c8acc6b to 8b149d5 Compare October 24, 2025 15:25
@bilyana-gospodinova bilyana-gospodinova marked this pull request as ready for review October 24, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Type: New feature github actions Pull requests that update GitHub Actions code test Test infrastructure, automated tests required, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test k6 tests in CI - rest java

3 participants