New cluster property - hazelcast.journal.cleanup.threshold [CTT-761, CTT-739] #1946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hardcore-allen-f5257d ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
shultseva
changed the title
shultseva
changed the title
Rob-Hazelcast
requested changes
Oct 20, 2025
Rob-Hazelcast
approved these changes
Oct 21, 2025
k-jamroz
reviewed
Oct 23, 2025
k-jamroz
reviewed
Oct 23, 2025
k-jamroz
reviewed
Oct 23, 2025
k-jamroz
reviewed
Oct 23, 2025
k-jamroz
reviewed
Oct 23, 2025
k-jamroz
reviewed
Oct 23, 2025
devOpsHazelcast
pushed a commit
to hazelcast/hazelcast
that referenced
this pull request
Oct 26, 2025
jira - https://hazelcast.atlassian.net/browse/CTT-761 Additional cleanup for **cache** is now triggered before the add operation. Cleanup runs on both the primary replica and backups. Cleanup starts only when the remaining capacity falls below a cleanup threshold. doc = hazelcast/hz-docs#1946 benchmark - https://github.com/hazelcast/internal-benchmarks/pull/67 Checklist: - [x] Labels (`Type:`, `Source:`, `Module:`) and Milestone set - [x] Label `Add to Release Notes` or `Not Release Notes content` set - [x] Label `All Languages Should Check` set if making changes to the Java client API and it may effect non-Java clients. Setting this label will auto generate associated issues in all non-Java clients. - [x] Architecture Design Record (ADR) reviewed and signed-off if this PR represents a significant architectural change - [x] Request reviewers if possible - [x] New public APIs have `@Nonnull/@Nullable` annotations - [x] New public APIs have `@since` tags in Javadoc - [ ] Send backports/forwardports if fix needs to be applied to past/future releases GitOrigin-RevId: edb67ff4ad816187cb285ef7894b47c1b6032ed9
Co-authored-by: Krzysztof Jamróz <79092062+k-jamroz@users.noreply.github.com>
Co-authored-by: Krzysztof Jamróz <79092062+k-jamroz@users.noreply.github.com>
Co-authored-by: Krzysztof Jamróz <79092062+k-jamroz@users.noreply.github.com>
Co-authored-by: Krzysztof Jamróz <79092062+k-jamroz@users.noreply.github.com>
k-jamroz
reviewed
Oct 28, 2025
| | 1.0 | ||
| | float | ||
| | The cleanup threshold for the event journal, expressed as a fraction of its capacity (a value between 0.0 and 1.0). | ||
| When the remaining capacity falls below this threshold, a cleanup may be triggered during put operations to remove expired events (only if a xref:data-structures:event-journal.adoc#configuring-event-journal-ttl[time-to-live] for event journal is configured). |
There was a problem hiding this comment.
during put operations
I am wondering (maybe nit-picking) if it is clear that we mean here journal/ringbuffer put operation and not IMap/ICache put operation
k-jamroz
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cleanup threshold property for the event journal.
Introduced here:
https://hazelcast.atlassian.net/browse/CTT-739
https://hazelcast.atlassian.net/browse/CTT-761