ingest-storage: Do not deduplicate metadata by family name when unmarshalling #12804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
approved these changes
Sep 25, 2025
alexweav
force-pushed
the
alexweav/skip-dedupe-medadata
branch
from
797f425 to
56a9f11
Compare
alexweav
force-pushed
the
alexweav/skip-dedupe-metadata-impl
branch
from
36d540e to
6bc53ef
Compare
Co-authored-by: Marco Pracucci <marco@pracucci.com>
jhalterman
pushed a commit
that referenced
this pull request
Oct 2, 2025
…shalling (#12804) #### What this PR does This PR builds on the refactor in #12792. By default, RW2 deserialization deduplicates metric metadata by family name. All metadata beyond the first instance for a given family are discarded. This PR adds a new deserialization option, called `SkipDeduplicateMetadata`, plus a new `metadataSet` implementation that avoids the deduplication and preserves all given metadata and ordering. This is done so that we can preserve metadata to the letter, even if it conflicts, ensuring we [adhere to prometheus behavior](https://prometheus.io/docs/prometheus/latest/querying/api/#querying-metadata) particularly in RW1.0. RW1 requests don't have the duplication that natural RW2 requests tend to have. Natural RW2 requests will already be deduplicated in the distributor before they reach the ingest-storage layer, so this change does not add undue duplication for clients sending RW2.0 into Mimir. #### Which issue(s) this PR fixes or relates to contrib grafana/mimir-squad#2253 #### Checklist - [x] Tests updated. - [ ] Documentation added. - [ ] `CHANGELOG.md` updated - the order of entries should be `[CHANGE]`, `[FEATURE]`, `[ENHANCEMENT]`, `[BUGFIX]`. If changelog entry is not needed, please add the `changelog-not-needed` label to the PR. - [ ] [`about-versioning.md`](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/configure/about-versioning.md) updated with experimental features. --------- Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR builds on the refactor in #12792.
By default, RW2 deserialization deduplicates metric metadata by family name. All metadata beyond the first instance for a given family are discarded. This PR adds a new deserialization option, called
SkipDeduplicateMetadata, plus a newmetadataSetimplementation that avoids the deduplication and preserves all given metadata and ordering.This is done so that we can preserve metadata to the letter, even if it conflicts, ensuring we adhere to prometheus behavior particularly in RW1.0.
RW1 requests don't have the duplication that natural RW2 requests tend to have. Natural RW2 requests will already be deduplicated in the distributor before they reach the ingest-storage layer, so this change does not add undue duplication for clients sending RW2.0 into Mimir.
Which issue(s) this PR fixes or relates to
contrib https://github.com/grafana/mimir-squad/issues/2253
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.