Skip to content

Enforce vcrun2022 as a requirement #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2025
Merged

Enforce vcrun2022 as a requirement #1719

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d90ee3
Enforce vcrun2022 as a requirement
reiichi001 Aug 9, 2025
1b2adad
Enforce 14.40 or later
reiichi001 Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/XIVLauncher.Common.Windows/WindowsDalamudCompatibilityCheck.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ private static bool CheckLibrary(string fileName)

private static bool CheckVcRedists()
{
Log.Information("Checking for VC2015-2022 runtime > 14.30");
// snipped from https://stackoverflow.com/questions/12206314/detect-if-visual-c-redistributable-for-visual-studio-2012-is-installed
// and https://github.com/bitbeans/RedistributableChecker

Expand All @@ -64,6 +65,14 @@ private static bool CheckVcRedists()
@"SOFTWARE\Microsoft\DevDiv\VC\Servicing\14.0\RuntimeMinimum",
@"SOFTWARE\Microsoft\VisualStudio\14.0\VC\Runtimes\X64",
@"SOFTWARE\Classes\Installer\Dependencies\Microsoft.VS.VC_RuntimeMinimumVSU_amd64,v14",
@"SOFTWARE\Classes\Installer\Dependencies\VC,redist.x64,amd64,14.43,bundle",
@"SOFTWARE\Classes\Installer\Dependencies\VC,redist.x64,amd64,14.42,bundle",
@"SOFTWARE\Classes\Installer\Dependencies\VC,redist.x64,amd64,14.41,bundle",
@"SOFTWARE\Classes\Installer\Dependencies\VC,redist.x64,amd64,14.40,bundle",

// legacy checks. As of Dalamud 13.0.0, we need to enforce the user has vcrun2022, not just 2015+
/*
@"SOFTWARE\Classes\Installer\Dependencies\VC,redist.x64,amd64,14.39,bundle",
@"SOFTWARE\Classes\Installer\Dependencies\VC,redist.x64,amd64,14.38,bundle",
@"SOFTWARE\Classes\Installer\Dependencies\VC,redist.x64,amd64,14.37,bundle",
@"SOFTWARE\Classes\Installer\Dependencies\VC,redist.x64,amd64,14.36,bundle",
Expand All @@ -81,6 +90,7 @@ private static bool CheckVcRedists()
@"Installer\Dependencies\,,amd64,14.0,bundle",
// here's one for vcrun2015
@"SOFTWARE\Classes\Installer\Dependencies\{d992c12e-cab2-426f-bde3-fb8c53950b0d}"
*/
};

var dllPaths = new List<string>
Expand All @@ -102,8 +112,12 @@ private static bool CheckVcRedists()

var vcVersioncheck = vcregcheck.GetValue("Version") ?? "";

if (((string)vcVersioncheck).StartsWith("14", StringComparison.Ordinal)
|| ((string)vcVersioncheck).StartsWith("v14", StringComparison.Ordinal))
var regEntryVersionString = (string)vcVersioncheck;
if (regEntryVersionString.StartsWith("v"))
regEntryVersionString = regEntryVersionString.TrimStart('v');
Version.TryParse(regEntryVersionString, out var regEntryVersion);

if (regEntryVersion >= new Version("14.40.0"))
{
passedRegistry = true;
Log.Debug("Passed Registry Check with: " + path);
Expand Down