tests: make sure cleanup is called as expect when tests time out #4611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modification includes: 1. change 'echo' cmd in function force_terminate as a subshell, to ensure immediate buffer flush. Otherwise, extra stdout buffer in function cleanup may be redirected to stderr, in such a case, function call in cleanup may get something wrong. 2. change --foreground as a optional setting, since it affects signal detection and cleanup procedure. With this patch, by default, even if the use case times out, the cleanup process will proceed as expected. And the test env always keep clean after testcase exits. Fixes: gluster#4610 Related patches: run-tests.sh: stop test on Ctrl-C gluster@1f03309 tests: call cleanup on receiving external signals INT, TERM and HUP gluster@ea980a8 Signed-off-by: chenjinhao <chen.jinhao@zte.com.cn>
|
Hi, @xhernandez @pkalever , could you please review this patch when you have a moment？ Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modification includes:
With this patch, by default, even if the use case times out, the cleanup process will proceed as expected. And the test env always keep clean after testcase exits.
Fixes: #4610
Related patches:
run-tests.sh: stop test on Ctrl-C
1f03309
tests: call cleanup on receiving external signals INT, TERM and HUP
ea980a8