common : only allow filename as read_audio_data argument #3412
+19
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The read_audio_data API was confusingly designed to accept either a filename or raw audio buffer. The server example was the only one passing audio_file.content (raw buffer) directly, which worked until WHISPER_FFMPEG=yes where ffmpeg_decode_audio would try to treat the raw audio buffer as a filename after ma_decoder_init_file failed. Now we always write to a temp file first, making the API cleaner and more consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The read_audio_data API was confusingly designed to accept either a filename or raw audio buffer.
The server example was the only one passing audio_file.content (raw buffer) directly, which worked until WHISPER_FFMPEG=yes where ffmpeg_decode_audio would try to treat the raw audio buffer as a filename after ma_decoder_init_file failed.
Now the example server always writes to a temp file first, making the API cleaner and more consistent.