Skip to content

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Sep 4, 2025

Screen.Recording.2025-09-04.at.15.24.58.mov

will only work for upstream with permissive headers, which includes https://raw.githubusercontent.com.

To try, add https://raw.githubusercontent.com/galaxyproject/galaxy/5ccf97752b06234249d63fb133d66f1f2dbe70a5/test/functional/tools/cat_multiple_user_defined.yml

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek force-pushed the upload_user_defined_tools_from_url branch from 23a8f4e to 0f9712b Compare October 1, 2025 10:48
@mvdbeek mvdbeek marked this pull request as ready for review October 1, 2025 10:49
@github-actions github-actions bot added this to the 26.0 milestone Oct 1, 2025
@nsoranzo
Copy link
Member

nsoranzo commented Oct 1, 2025

Nice! As a small suggestion, I'd probably expect that once uploaded, the tool is also already saved (as for a dataset), not just shown in the editor.

Copy link
Member

@jmchilton jmchilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linting issues have been fixed in dev - if you rebased it I would merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants