Skip to content

Conversation

jmchilton
Copy link
Member

It would work properly the first time but then regress on reload and resave in the form because this initialization logic wasn't taking into account optional parameter types.

How to test the changes?

(Select all options that apply)

  • Instructions for manual testing are as follows:
    1. Open the workflow editor and add a sample sheet input to the workflow.
    2. Add a column by clicking the step and scrolling down the right panel.
    3. Make the column an optional integer. Swap the default of "0" to an empty input box.
    4. Save the workflow - notice the "null" default is saved properly over the wire.
    5. Reload the workflow - notice that without this change the empty input box for the default has become "0".

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

It would work properly the first time but then regress on reload and resave in the form because this initialization logic wasn't taking into account optional parameter types.
@jmchilton jmchilton marked this pull request as ready for review August 28, 2025 16:53
@github-actions github-actions bot added this to the 25.1 milestone Aug 28, 2025
@mvdbeek mvdbeek merged commit d94a088 into galaxyproject:dev Oct 1, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants