Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

Conversation

mapix
Copy link
Contributor

@mapix mapix commented Jun 22, 2024

For better code quality, it's advisable to fix the tests before merging this PR:

Also, ensure that development dependencies remain consistent with the release environment:

@mapix mapix changed the title prepare changelog for the next release [WIP] prepare changelog for the next release Jun 22, 2024
@mapix mapix changed the title [WIP] prepare changelog for the next release WIP: prepare changelog for the next release Jun 22, 2024
@mapix mapix changed the title WIP: prepare changelog for the next release prepare changelog for the next release Jun 22, 2024
@mapix mapix changed the title prepare changelog for the next release Prepare changelog for the next release Jun 22, 2024
@mapix
Copy link
Contributor Author

mapix commented Jun 22, 2024

@fohrloop Please help confirm if these preparations are sufficient for releasing the next version. If anything else is needed, please list it. Since it might be better to update the specific version number at the time of release, I have not updated the version number.

@fohrloop
Copy link
Owner

Hi @mapix and thank you for creating the PR!

I think the description of this PR has a mistake as this does not fix issue 111 or issue 133, but updates the changelog. There's another file change in tests/test_uploading_same_file_twice_with_errors.py which skips a test to make the tests work on linux/macos. Could you please split the PR into two as it's addressing two things?

  1. Updating Changelog
  2. Fixing tests on macos/linux

about next release: dash-uploader 0.7.0

  • As the previous release was a pre-release (0.7.0-a1), I suggest we remove the title "0.7.0-a1 (2022-03-30)" from the changelog and replace it with "0.7.0 (unreleased)". In other words, let's aggregate the pre-release release notes with the 0.7.0 release notes, because people reading just the 0.7.0 release notes could accidentally miss what's new or changed.
  • It mentions that update package and optimize dev env  #128 fixed AttributeError: module 'packaging.version' has no attribute 'LegacyVersion' #111, but it seems that it only fixes the issue when installing with the [dev] extras. I think the fix should be changing this line in the setup.py:
    install_requires=["dash>=1.1.0", "packaging>= 21.0"],

to

    install_requires=["dash>=1.1.0", "packaging>22"],

if a fix is provided, let's put that also through a separate PR (one PR per a thing).

@GitHunter0
Copy link

Hey @mapix , just checking with you, have you seen the @fohrloop feedback?

I'm really hoping for the next dash-uploader release, specially due to the packaging version requirement.

@mapix mapix force-pushed the feat/prepare-next-release branch from f05cb42 to e7e9734 Compare August 17, 2024 16:48
@mapix mapix changed the title Prepare changelog for the next release update changelog for next 0.7.0 up-comming release Aug 17, 2024
@mapix
Copy link
Contributor Author

mapix commented Aug 17, 2024

@fohrloop

Thanks for your advice. I missed this PR as I'm recently between jobs. I have followed your advice and separated all sub-PRs. Except for the packaging version, which I tested with 21.0 that everything works on the current codebase.

@fohrloop
Copy link
Owner

@mapix thanks a lot! I think we can keep this PR open until all the changes coming to the next releases are merged, and then have a final touch on the changelog.

Do you think it would make sense to update some of the JS packages before the release? My npm audit shows:

39 vulnerabilities (8 moderate, 25 high, 6 critical)

which looks a bit worrying to me. Or what do you think? There's also quite a list of outdated JS packages shown by npm outdated. What's your JS skill level?

@fohrloop fohrloop changed the title update changelog for next 0.7.0 up-comming release update changelog for the next release (0.7.0) Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants