[UI] Redesign File Manager without new logic #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyfreeman
suggested changes
Dec 2, 2024
| .string | ||
| .split(separator: "/") | ||
| .map(String.init) | ||
| .filter { $0 != "ext" } |
There was a problem hiding this comment.
this will filter child ext folders
| case file(File) | ||
| case directory(Directory) | ||
|
|
||
| public var id: String { name } |
There was a problem hiding this comment.
will conflict with elements from another location (in search view for instance)
Programistich
force-pushed
the
feature/file-manager
branch
from
ffd340b to
3f38442
Compare
tonyfreeman
force-pushed
the
feature/file-manager
branch
2 times, most recently
from
050cdfe to
c6aea69
Compare
tonyfreeman
reviewed
Jan 9, 2025
Comment on lines
23
to
27
| @AppStorage(.fileManagerShowHiddenFiles) | ||
| private var isHiddenFilesShow: Bool = false | ||
|
|
||
| @AppStorage(.fileManagerDisplayType) | ||
| private var displayType: DisplayType = .list |
There was a problem hiding this comment.
Could you extract this into single Settings structure?
tonyfreeman
reviewed
Feb 12, 2025
Comment on lines
27
to
33
| @State private var name = "" | ||
| @State private var isNewFile = false | ||
| @State private var isNewDirectory = false | ||
| @FocusState var isNameFocused: Bool | ||
| var namePlaceholder: String { | ||
| "\(isNewFile ? "file" : "directory") name" | ||
| } |
There was a problem hiding this comment.
Can we use separate model for this?
tonyfreeman
reviewed
Feb 12, 2025
| } catch { | ||
| self.error = String(describing: error) | ||
| self.error = String(describing: error) |
There was a problem hiding this comment.
please run linter to fix this kind of typos
Programistich
force-pushed
the
feature/file-manager
branch
from
74eb51a to
ab7f3c8
Compare
Programistich
force-pushed
the
feature/file-manager
branch
from
ab7f3c8 to
e3bc85d
Compare
Programistich
force-pushed
the
feature/file-manager
branch
from
e3bc85d to
cbb74ba
Compare
|
Could you add an screenshot of how it looks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.