Fix bug in t-spd_lll_reduce #2404
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in$$(\delta, \eta)$$ may return a non-identity result even if the input matrix is $$(\delta,\eta)$$ -LLL reduced.
t-spd_lll_reduce
due to the fact thatfmpz_lll_reduce
with parametersFixed by the following changes:
arb_mat_spd_lll_reduce
andarb_mat_spd_is_lll_reduced
.t-spd_lll_reduce
now checks that the output is the identity matrix only if the input isAdditionally fixes a missing
flint_abort
.