Skip to content

Conversation

j-kieffer
Copy link
Contributor

There was a bug in t-spd_lll_reduce due to the fact that fmpz_lll_reduce with parameters $$(\delta, \eta)$$ may return a non-identity result even if the input matrix is $$(\delta,\eta)$$-LLL reduced.
Fixed by the following changes:

  • Add $$\delta, \eta$$ as parameters in arb_mat_spd_lll_reduce and arb_mat_spd_is_lll_reduced.
  • t-spd_lll_reduce now checks that the output is the identity matrix only if the input is $$(\delta,\eta)$$-reduced with $$\delta>1$$ and $$\eta<1/2$$.

Additionally fixes a missing flint_abort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant