Skip to content

[Hdfs Utils] add uri param to filesystem get api #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Hdfs Utils] add uri param to filesystem get api #1219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions feathr-impl/src/main/scala/com/linkedin/feathr/offline/util/HdfsUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import org.apache.hadoop.fs.{FileSystem, LocatedFileStatus, Path, PathFilter, Re
import org.apache.log4j.{Logger, PatternLayout, WriterAppender}

import java.io.{FileSystem => _, _}
import java.net.URI
import java.time.format.DateTimeFormatter
import java.time.temporal.ChronoUnit
import java.time.{LocalDateTime, ZoneId, ZoneOffset}
Expand Down Expand Up @@ -451,7 +452,7 @@ object HdfsUtils {
* @return true if exists else false.
*/
def exists(path: String, conf: Configuration = conf): Boolean = {
FileSystem.get(conf).exists(new Path(path))
FileSystem.get(URI.create(path), conf).exists(new Path(path))
}

/**
Expand Down Expand Up @@ -489,7 +490,7 @@ object HdfsUtils {
* @return true if nonEmpty
*/
def nonEmpty(inputPath: String, conf: Configuration = conf): Boolean = {
val fs = FileSystem.get(conf)
val fs = FileSystem.get(URI.create(inputPath), conf)
val path = new Path(inputPath)
if (!exists(inputPath)) return false
if (fs.getFileStatus(path).isDirectory) {
Expand Down