Skip to content

docs: Rename TrinoSource Parameters to match updated API #5682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2025
Merged

docs: Rename TrinoSource Parameters to match updated API #5682

merged 2 commits into from
Oct 23, 2025

Conversation

@cutoutsy
Copy link
Contributor

doc: rename TrinoSource parameters to match updated API

  • Change event_timestamp_column to timestamp_field
  • Change table_ref to table

doc: rename TrinoSource parameters to match updated API
96da757 
Signed-off-by: fengxiaochuan <fengxiaochuan@corp.netease.com>
@cutoutsy cutoutsy requested a review from a team as a code owner October 20, 2025 06:37
HaoXuAI
HaoXuAI approved these changes Oct 20, 2025
View reviewed changes
Copy link
Collaborator

@HaoXuAI HaoXuAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cutoutsy cutoutsy changed the title doc: rename TrinoSource parameters to match updated API docs: rename TrinoSource parameters to match updated API Oct 20, 2025
@cutoutsy
Copy link
Contributor Author

cutoutsy commented Oct 20, 2025 •
edited
Loading

please help rerun the failed checks, thanks @HaoXuAI

@franciscojavierarceo franciscojavierarceo changed the title docs: rename TrinoSource parameters to match updated API docs: Rename TrinoSource parameters to match updated API Oct 20, 2025
@cutoutsy cutoutsy changed the title docs: Rename TrinoSource parameters to match updated API docs: Rename TrinoSource Parameters to match updated API Oct 21, 2025
@cutoutsy
Copy link
Contributor Author

can rerun the failed checks or skip @franciscojavierarceo

@cutoutsy
Copy link
Contributor Author

can merge this pr @franciscojavierarceo

@ntkathole ntkathole merged commit c6971d2 into feast-dev:master Oct 23, 2025
19 checks passed
@cutoutsy cutoutsy deleted the doc/trino_source_doc branch October 23, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HaoXuAI HaoXuAI HaoXuAI approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cutoutsy @HaoXuAI @ntkathole