Skip to content

Add (client only) support for rda3 #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Add (client only) support for rda3 #348

wants to merge 15 commits into from

Conversation

wirew0rm
Copy link
Member

@wirew0rm wirew0rm commented Jul 5, 2024

This adds support for RDA3, the protocol used by CMW/FESA based devices.

  • Fixes some quirks in the cmwlight serialiser that are needed to serialize the control messages:
    • support for maps
    • deserialise empty objects/maps
    • some minor bugs
    • add unittests with real world data to prevent regressions
  • Adds a lightweight zeromq STREAM based nameserver client to resolve rda3 device names
  • Add a cmwlight client implementation

There are still some open points, for now only get requests are handled completely, subscriptions generally work but need a bit more state-tracking to be reliable

  • finish the state machine
  • replace some fixed strings with the actual data (e.g. client information)
  • integrate the name server into the client.
  • general code cleanup

@wirew0rm wirew0rm had a problem deploying to configure coverage July 5, 2024 12:57 — with GitHub Actions Failure
@wirew0rm wirew0rm had a problem deploying to configure coverage July 5, 2024 12:57 — with GitHub Actions Failure
@wirew0rm wirew0rm had a problem deploying to configure coverage July 5, 2024 12:57 — with GitHub Actions Failure
@wirew0rm wirew0rm had a problem deploying to configure coverage July 5, 2024 12:57 — with GitHub Actions Failure
@wirew0rm wirew0rm had a problem deploying to configure coverage July 5, 2024 12:57 — with GitHub Actions Failure
@wirew0rm wirew0rm had a problem deploying to configure coverage July 5, 2024 12:57 — with GitHub Actions Failure
@wirew0rm wirew0rm had a problem deploying to configure coverage July 8, 2024 21:04 — with GitHub Actions Failure
@wirew0rm wirew0rm had a problem deploying to configure coverage July 8, 2024 21:04 — with GitHub Actions Failure
@wirew0rm wirew0rm had a problem deploying to configure coverage July 8, 2024 21:04 — with GitHub Actions Failure
@wirew0rm wirew0rm had a problem deploying to configure coverage July 8, 2024 21:04 — with GitHub Actions Failure
@wirew0rm wirew0rm had a problem deploying to configure coverage July 8, 2024 21:04 — with GitHub Actions Failure
@wirew0rm wirew0rm had a problem deploying to configure coverage July 8, 2024 21:04 — with GitHub Actions Failure
@wirew0rm wirew0rm had a problem deploying to configure coverage July 9, 2024 06:57 — with GitHub Actions Failure
@wirew0rm wirew0rm had a problem deploying to configure coverage July 9, 2024 06:57 — with GitHub Actions Failure
@wirew0rm wirew0rm had a problem deploying to configure coverage July 9, 2024 06:57 — with GitHub Actions Failure
@wirew0rm wirew0rm had a problem deploying to configure coverage July 9, 2024 06:57 — with GitHub Actions Failure
@wirew0rm wirew0rm had a problem deploying to configure coverage July 9, 2024 06:57 — with GitHub Actions Failure
@wirew0rm wirew0rm had a problem deploying to configure coverage July 9, 2024 06:57 — with GitHub Actions Failure
wirew0rm and others added 10 commits January 15, 2025 14:26
@wirew0rm
CI: update image and action versions
88e7895 
Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
@wirew0rm
Implementation of rda3 Directory Client
73d0ebf 
Implemented using the ZMQ NATIVE pattern s.t. it can use the same
pollers and zmq context as the client itself.

Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
Signed-off-by: Alexander Krimm <alex@wirew0rm.de>
Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
@wirew0rm
CMWLightSerialiser: enable support for std::map and nesting
77110a0 
Support for nested Datastructures was not implemented correctly before
because only serialise + deserialise was checked but not the actual
serialised output.

Signed-off-by: Alexander Krimm <alex@wirew0rm.de>
Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
@wirew0rm
Add parsing rda3 data into a map
27988d4 
Also allows fieldnames with starting with a numeric value by prefixing
them with ' x_'.

Signed-off-by: Alexander Krimm <alex@wirew0rm.de>
Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
@wirew0rm
CmwLightSerialiser: fix handling of empty nested objects/maps
5cf7682 
Signed-off-by: Alexander Krimm <alex@wirew0rm.de>
Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
@wirew0rm
WIP implementation of cmwlight client
ce09ded 
Signed-off-by: Alexander Krimm <alex@wirew0rm.de>
Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
@restyled-commits @wirew0rm
Restyled by clang-format
8e018fd 
Signed-off-by: Alexander Krimm <alex@wirew0rm.de>
Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
@wirew0rm
fix warinings
f4f9e49 
Signed-off-by: Alexander Krimm <alex@wirew0rm.de>
Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
@wirew0rm
Fix build for other compilers
17b0a1e 
Signed-off-by: Alexander Krimm <alex@wirew0rm.de>
Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
@restyled-commits @wirew0rm
Restyled by clang-format
bcfe871 
Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
@wirew0rm
CmwLightSerialiser: fix cornercases wip
f1c27fb
@wirew0rm
Small fixes to CMW light client
db53aa4
@wirew0rm
IoSerialiserCmwLight: add std::variant serialiser
6706944 
Serialisation only, as deserialisation is not possible due to the
IoSerialiser expecting to be able to deduce the type of the field at
compile time via `IoSerialiser<Proto, T>::getTypeId()`.
@wirew0rm
Work on subscriptions, can subscribe successfully, now needs state ma…
48e6811 
…chine for processing replies
@wirew0rm
wip
26c48d3
@wirew0rm wirew0rm temporarily deployed to configure coverage January 15, 2025 13:36 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage January 15, 2025 13:36 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage January 15, 2025 13:36 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage January 15, 2025 13:36 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage January 15, 2025 13:36 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage January 15, 2025 13:36 — with GitHub Actions Inactive
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
13.8% Coverage on New Code (required ≥ 80%)
10.8% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wirew0rm @restyled-commits