fix(execute): relax gas validation rule for non benchmark mode #2269
+7
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
In PR #2219, we added a gas validation rule for
execute
mode that assumes full block gas consumption. This should apply only to benchmark mode, non-benchmark tests don’t have this requirement and should bypass gas validation.Verification
Running anvil for quick verification:
anvil --accounts 1 --balance 300
Some environment variable from anvil local network:
127.0.0.1:8545
0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80
Test Cases:
🔗 Related Issues or PRs
This would affect Issue #2255 and PR #2266 , and there is issue reported by ethPandaOps that affect testing.
✅ Checklist
tox
checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
type(scope):
.mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_from
marker.