Skip to content

Conversation

LouisTsai-Csie
Copy link
Collaborator

@LouisTsai-Csie LouisTsai-Csie commented Oct 6, 2025

🗒️ Description

In PR #2219, we added a gas validation rule for execute mode that assumes full block gas consumption. This should apply only to benchmark mode, non-benchmark tests don’t have this requirement and should bypass gas validation.

Verification

Running anvil for quick verification: anvil --accounts 1 --balance 300
Some environment variable from anvil local network:

  • chain id: 31337
  • rpc link: 127.0.0.1:8545
  • rpc seed key: 0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80

Test Cases:

  • Benchmark Mode: uv run execute remote tests/benchmark/test_worst_compute.py::test_worst_jumps -m benchmark --gas-benchmark-values 1 --chain-id 31337 --rpc-seed-key 0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80 --rpc-endpoint http://127.0.0.1:8545 --fork Prague
  • Consensus Mode: uv run execute remote tests/prague/eip7702_set_code_tx/test_set_code_txs.py --chain-id 31337 --rpc-seed-key 0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80 --rpc-endpoint http://127.0.0.1:8545 --fork Prague

🔗 Related Issues or PRs

This would affect Issue #2255 and PR #2266 , and there is issue reported by ethPandaOps that affect testing.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

@LouisTsai-Csie LouisTsai-Csie self-assigned this Oct 6, 2025
@LouisTsai-Csie LouisTsai-Csie marked this pull request as ready for review October 6, 2025 13:21
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks :)

@spencer-tb spencer-tb merged commit 0751556 into ethereum:main Oct 6, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants