-
Notifications
You must be signed in to change notification settings - Fork 177
β¨ feat(tests): EIP-7928 No-op and adjacent test case #2178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
raxhvl
wants to merge
13
commits into
main
Choose a base branch
from
feat/eip-7928/test-noop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
f3ef32a
to
97e7edc
Compare
4b4405a
to
ccd2966
Compare
85480d5
to
179c570
Compare
fselmo
approved these changes
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @raxhvl, I think this is good to go but can use your eyes as a sanity check before merging. Some things to note:
- As we talked about, I updated the empty account expectations to use
BalAccountExpectation.empty()
explicitly here. We raise if ambiguousBalAccountExpectation()
is used. I think this explicitness is much nicer for a reader / implementer. I added unit tests for these as well. - I removed a duplicate test. It looks like the fully unmutated test was exactly the same as the
bal_noop_storage_write
test except for checking the storage read, which I added to the latter and removed the former here. - I also moved the tests into the main file and added a changelog entry.
Let me know if you think this is good to go as well and we can get this merged π. Thanks for your work on all these ππΌ
179c570
to
5b0d5cb
Compare
5b0d5cb
to
faed742
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
scope:tests
Scope: Changes EL client test cases in `./tests`
type:feat
type: Feature
type:test
Type: Add/refactor fw unit tests; no fw or el client test case changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ποΈ Description
Adds No-op and no-op adjacent test cases for EIP-7928
π Related Issues or PRs
β Checklist
tox
checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
type(scope):
.