Skip to content

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Jul 26, 2025

🗒️ Description

Adds support for the --opcode.count parameter added in ipsilon/evmone#1274.

This is still in draft but already helped on #1935 to get the diffs in opcode counts from before and after the PR.

🔗 Related Issues or PRs

Closes #1852

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

@marioevz marioevz force-pushed the evm-opcode-counter branch from 59cefc0 to 5443996 Compare October 2, 2025 20:25
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marioevz this looks very good to me.

Love the addition to the fixture _info field:
image

As a follow-up PR, should we diff the expected opcode count (as defined by the bytecode) with that from evmone-t8n if different during filling? Or did you consider that going too far?

@jochem-brouwer
Copy link
Member

This is extremely helpful in some situations especially that it is being added to the fixtures info field. For benchmarks esp. regarding gas pricing it would be super helpful to include this in the fixtures by default (so also on the releases). Could this be done?
CC @misilva73

Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Working from my side too. LGTM

@spencer-tb spencer-tb added type:feat type: Feature t8ntools Third party t8n tools support labels Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t8ntools Third party t8n tools support type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(fill): decide on an "opcode count" t8n interface
4 participants