Skip to content

Conversation

SergioGasquez
Copy link
Member

No description provided.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a --no-addresses flag to the monitor command to disable address resolution for smaller log output. The change allows users to skip loading symbols and function name lookups to reduce output verbosity.

  • Added a new no_addresses boolean field to MonitorConfigArgs
  • Created a new constructor new_no_addresses for ResolvingPrinter that disables symbol loading and address resolution
  • Updated monitor logic to conditionally create the appropriate printer based on the flag

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
espflash/src/cli/mod.rs Adds the no_addresses command-line flag to MonitorConfigArgs
espflash/src/cli/monitor/mod.rs Updates monitor function to use the new flag and includes it in monitor args checking
espflash/src/cli/monitor/parser/mod.rs Adds disable_address_resolution field and new_no_addresses constructor to ResolvingPrinter

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SergioGasquez SergioGasquez linked an issue Sep 10, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a flag to disable resolving addresses
1 participant