kernel: prevent crash when calling io:getopts when user_drv is down #10283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 3 files 158 suites 2h 20m 57s ⏱️ For more details on these failures, see this check. Results for commit a82dd40. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
frazze-jobb
force-pushed
the
frazze/kernel/fix_io_getopts_crash/OTP-19812
branch
from
1924db1 to
a82dd40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shell would crash when the
io:getopts()call got timeout when fetching state from the io process.Before
io:scan_erl_exprswould have returned{error,terminated}but as of introduction of explicit handling of when to save shell history, the failure is happening earlier.In this commit I add a check that makes
io:getopts()return{error,terminated}in the case the driver process is down.A check is also added on the shell side.