CT: Add source filename in error output when possible #10269
+19
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PoC for #10260
I figured that I would get the filename from the same place exceptions already do since it's the most appropriate and there's no need to tweak the filename. With this filename I could then have GitHub annotate PRs with the exact failure location.
In the shell it looks like this:
Or
I haven't added tests, let's see if this is an approach that would be OK first.