chore: bump packages and convert test-app to strict template tag #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aklkv
force-pushed
the
chore/bump-packages
branch
3 times, most recently
from
093315f to
35f17c8
Compare
aklkv
commented
Jun 16, 2025
|
|
||
| export interface NavigationNarratorSignature { | ||
| Args: { | ||
| /** Whether to include the skip link. Defaults to `true`. */ |
There was a problem hiding this comment.
all this will show up like so in VS code at least
Screen.Recording.2025-06-15.at.6.36.51.PM.mov
aklkv
commented
Jun 16, 2025
| * | ||
| * Usage: | ||
| * ```gts | ||
| * import { NavigationNarrator } from 'ember-a11y-refocus'; |
There was a problem hiding this comment.
it also turns out that we can not use @ symbols even inside of fenced blocks as it trips up markdown somehow, but this is good enough IMO
|
@MelSumner I think this is ready for review, I can look into moving this addon to newer blueprint after this is merged |
josephdsumner
approved these changes
Sep 20, 2025
|
Apologies, can you resolve the merge conflicts? |
aklkv
force-pushed
the
chore/bump-packages
branch
from
0fe9aff to
d92b22a
Compare
…late-compilation`
aklkv
force-pushed
the
chore/bump-packages
branch
from
d92b22a to
beb7689
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.