Add user context to invite preview screen #30654
Draft
+381
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
commented
Sep 1, 2025
| } | ||
|
|
||
| function useGetUserSafety(inviterMember: RoomMember | null): { | ||
| score: InviteScore | null; |
There was a problem hiding this comment.
This is unused now since we don't have a headline score.
Half-Shot
commented
Sep 1, 2025
| setIsLocalTrustedServer(false); | ||
| } | ||
|
|
||
| (async () => { |
There was a problem hiding this comment.
We might need to remove this, it was rather flaky.
Half-Shot
commented
Sep 1, 2025
| ); | ||
| } | ||
|
|
||
| function useGetUserSafety(inviterMember: RoomMember | null): { |
There was a problem hiding this comment.
It may be useful to factor this out, we might use it in other parts of the UI.
Half-Shot
commented
Sep 1, 2025
| } | ||
|
|
||
| const { roomCount, joinedTo, userBanned, userKicked, userFirstSeen, isLocalTrustedServer } = details; | ||
| return ( |
There was a problem hiding this comment.
Aaaaaaaaaaaall of this needs i18n-ing
Half-Shot
commented
Sep 1, 2025
| Unsafe = "unsafe", | ||
| } | ||
|
|
||
| function SafetyDetailItem({ |
There was a problem hiding this comment.
Potentially a candidate for Compound-ing, will check with design.
Half-Shot
commented
Sep 1, 2025
| (async () => { | ||
| let rooms: string[]; | ||
| try { | ||
| rooms = await client._unstable_getSharedRooms(inviterMember.userId); |
There was a problem hiding this comment.
This might not actually be useful if we already have a store of rooms locally.
This was referenced Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19620
For element-hq/element-meta#1366
This adds some additional context to the invite preview screen in Element so that you can roughly figure out how much you trust an invite from another person. This is another tool for users to feel safer on Matrix by having instant context to how they might relate to another user.
This does not currently rely on any third party services to provide context, all the information is taken from clientside held events. This means we don't always have a complete picture of a user's activities, but it neither leaks any information to you or to the server.
This has gone through light review with @element-hq/trust-safety but needs both product review
and design reviewto really progress.Design docs: https://www.figma.com/design/OK9VOhqfATe9eLdhV8qaZC/User-Context-on-Invite-Preview?node-id=1-632&p=f&t=7NqTf2JSEyPC4yrJ-0
Screenshot
Checklist
public/exportedsymbols have accurate TSDoc documentation.