Selection and hover backgrounds #183
Conversation
There was a problem hiding this comment.
Looks good to me, although without context, the naming it isn't clear exactly where these new tokens fit in to the system. For example we have
bg/primary/rest, bg/primary/hovered & bg/primary/pressed
bg/secondary/rest, bg/secondary/hovered & bg/secondary/pressed
bg/accent/rest, bg/accent/hovered, bg/accent/pressed & bg/accent/selected
where the specific states are related to the intended use. Are these new ones intended to be used against e.g. bg/canvas/default, bg/subtle/primary and bg/subtle/secondary, or just one of them?
Which is a roundabout way of asking if these would make more sense to be bg/canvas/hovered and bg/canvas/selected?
| "color.gradient.super": "S:012790c8c979c2e2d44a175382ee3b5865467656,", | ||
| "color.gradient.action.linear": "S:f429bb5c10c2aa662f844bdaaaa0378fdac2bdfa," | ||
| "color.gradient.action.linear": "S:f429bb5c10c2aa662f844bdaaaa0378fdac2bdfa,", | ||
| "color.bg.badge.default": "S:2e389dd1535965b7704292fcaeac993cfe68887b,", |
There was a problem hiding this comment.
I'm not sure where this one has come from 🤔
There was a problem hiding this comment.
Looks like the last time the file was regenerated was part of the way through #147. I believe this file has to be exported manually from Tokens Studio?
| "color.bg.selection": "S:aafc47c563900ea23df3a4d400255fbba2bf8daa,", | ||
| "color.bg.hover": "S:3b12413853bf0d7841fd64b2dc8da9dd61e7639e," |
There was a problem hiding this comment.
Maybe these should be .selected and .hovered for consistency with other tokens in the system?
Accessible selection and hover backgrounds (roomlist, settings etc)