Skip to content

Conversation

kruskall
Copy link
Member

Motivation/summary

increase the number of max requests on large instances (8Gb+) by using a bigger multiplier (1.5 -> 3.0)

increase in memory usage is minimal but the increased requests are enough to push ES more, especially on arm instances

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

run apm-server in a docker image and set the container memory to < 8Gb

Related issues

increase the number of max requests on large instances (8Gb+) by
using a bigger multiplier (1.5 -> 3.0)

increase in memory usage is minimal but the increased requests
are enough to push ES more, especially on arm instances
@kruskall kruskall requested a review from a team as a code owner August 26, 2025 16:46
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kruskall kruskall added the backport-active-all Automated backport with mergify to all the active branches label Aug 26, 2025
marclop
marclop previously approved these changes Aug 26, 2025
1pkg
1pkg previously approved these changes Aug 26, 2025
max request expected default value went from 22 to 34
for 8gb instances
@kruskall kruskall dismissed stale reviews from 1pkg and marclop via cb43d98 August 26, 2025 19:23
@kruskall kruskall requested review from 1pkg and marclop August 26, 2025 19:29
Copy link
Member

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: do we really plan to backport to all active branch patch versions, even for 9.0? I can understand 8.19 and kind of understand 9.1 but not too sure about 9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-active-all Automated backport with mergify to all the active branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants