Skip to content

breadcum issue fixed in pgr service #2992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

breadcum issue fixed in pgr service #2992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion health/micro-ui/web/micro-ui-internals/packages/modules/pgr/src/pages/employee/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const EmployeeApp = ({ path, stateCode, userType, tenants }) => {
{
internalLink: `/${window?.contextPath}/employee/pgr/inbox-v2`,
content: t("PGR_INBOX"),
show: location.pathname.includes("inbox"),
show: location.pathname.includes("inbox") || location.pathname.includes("complaint-details"),
},
Comment on lines 55 to 58
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Prefer route-aware matching (matchPath) over substring includes

Using includes on pathname can produce false positives and is brittle if routes evolve (e.g., inbox-v3 or localized paths). Suggest matching against the configured route patterns using react-router’s matchPath and the existing base path prop for consistency.

Apply this diff within the current segment to delegate to a named boolean:

-                show: location.pathname.includes("inbox") || location.pathname.includes("complaint-details"),
+                show: showInboxCrumb,

Add the following supporting changes elsewhere in this file:

  • Import:
import { matchPath } from "react-router-dom";
  • Compute the booleans (place after useLocation and before the return):
const showInboxCrumb = Boolean(
  matchPath(location.pathname, { path: `${path}/inbox-v2`, exact: false }) ||
  matchPath(location.pathname, { path: `${path}/complaint-details/:id`, exact: false })
);

{
internalLink: `/${window?.contextPath}/employee/pgr/complaint-details`,
Expand Down
Loading