Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
edc8262
fetch_bills_screen - open overlay on click
ishaan-egov May 6, 2025
667fe22
removed unwanted
ishaan-egov May 6, 2025
a388aef
fetch bills screen
ishaan-egov May 9, 2025
aa4554b
verify and generate screen
ishaan-egov May 9, 2025
d69509c
bill details screen and table
ishaan-egov May 13, 2025
ae3a674
edit flow/api integ/other stuff
ishaan-egov May 26, 2025
e78cdba
minor change
ishaan-egov May 29, 2025
58350da
change
ishaan-egov May 29, 2025
4c9e3c8
individual search, selected count
ishaan-egov May 30, 2025
ade15e5
individual details and bill api calls
ishaan-egov Jun 2, 2025
f343ff9
added pagination in bill Details, popups, changes for edit flow
ishaan-egov Jun 4, 2025
a2e2675
wage related changes, editBills prop
ishaan-egov Jun 6, 2025
dc85a01
edit link
ishaan-egov Jun 11, 2025
b58ca0d
minor changes
ishaan-egov Jun 11, 2025
090aae4
API integration - update bill, verify endpoint, demo changes
ishaan-egov Jun 18, 2025
71b5f6d
loader for verify api
ishaan-egov Jun 19, 2025
48401f5
mno and worker days
ishaan-egov Jun 19, 2025
d704b8c
locale update
ishaan-egov Jun 19, 2025
1bb703a
title updated
ishaan-egov Jun 19, 2025
fdbac08
removed download
ishaan-egov Jun 19, 2025
c537863
page title, endpoint added
ishaan-egov Jun 24, 2025
2320907
payments api integration bill Lvl
ishaan-egov Jun 24, 2025
62203fa
header change
ishaan-egov Jun 24, 2025
4e611d9
editor's flow - update bulk individual api integration, workflow update
ishaan-egov Jun 24, 2025
0a24097
disabled selection , updated status for showing tooltip
ishaan-egov Jun 27, 2025
5b38d60
changes in tabs and their actions, changes as per api modifications
ishaan-egov Jun 27, 2025
d31476b
send for at bill level
ishaan-egov Jun 27, 2025
c8463ef
success response page after Updating bill detail
ishaan-egov Jun 27, 2025
8537f9f
bill and bill details update , CREATE action in wf (//TODO)
ishaan-egov Jun 27, 2025
dee7e0e
POLLING_INTERVAL change
ishaan-egov Jun 27, 2025
8daa7bf
added assignee, api for hrms user search, verify api polling logic,
ishaan-egov Jun 30, 2025
e8eb984
payment and verify api at bill details level, added wf and business s…
ishaan-egov Jul 2, 2025
61b77a3
error fix in my bills
ishaan-egov Jul 2, 2025
3d887bd
clear selected rows and checkbox after action/tabs switch, added aler…
ishaan-egov Jul 3, 2025
ca80dd7
added resolutions in package.json
ishaan-egov Jul 3, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
rel='stylesheet' type='text/css'>
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="theme-color" content="#00bcd1" />
<title>Burundi HCM</title>
<title>Congo HCM</title>
<link rel="stylesheet" href="https://unpkg.com/@egovernments/digit-ui-css@1.8.12/dist/index.css" />
<link rel="stylesheet" href="https://unpkg.com/@egovernments/digit-ui-components-css@0.0.2-beta.44/dist/index.css" />
<link rel="stylesheet" href="https://unpkg.com/@egovernments/digit-ui-health-css@0.2.47/dist/index.css" />
Expand All @@ -19,8 +19,96 @@

<!-- <link rel="stylesheet" href="https://unpkg.com/@egovernments/digit-ui-css/dist/index.css"/> -->
<!-- <script src="https://s3.ap-south-1.amazonaws.com/egov-dev-assets/globalConfigs.js"></script> -->
<script src="%REACT_APP_GLOBAL%"></script>

<!-- <script src="%REACT_APP_GLOBAL%"></script> -->
<script>
var globalConfigs = (function () {
var contextPath = "payments-ui";
var projectContext = "project";
var individualContext = "individual";
var attendanceContext = "attendance";
var musterRollContext = "health-muster-roll";
var expenseContext = "health-expense";
var expenseCalculatorContext = "health-expense-calculator";
var stateTenantId = "cg";
var gmaps_api_key = "AIzaSyAASfCFja6YxwDzEAzhHFc8B-17TNTCV0g";
var configModuleName = "commonUiConfig";
var centralInstanceEnabled = false;
var localeRegion = "CG";
var localeDefault = "en";
var mdmsContext = "mdms-v2";
var hrmsContext = "egov-hrms";
var hierarchyType = "ADMIN";
var footerBWLogoURL =
"https://unified-dev.digit.org/egov-dev-assets/digit-footer-bw.png";
var footerLogoURL =
"https://unified-dev.digit.org/egov-dev-assets/digit-footer.png";
var digitHomeURL = "https://www.digit.org/";
var assetS3Bucket = "egov-dev-assets";
var calculationPageAssets = "https://egov-health-dev-assets.s3.ap-south-1.amazonaws.com/calculation-page-assets/"
var getConfig = function (key) {
if (key === "STATE_LEVEL_TENANT_ID") {
return stateTenantId;
} else if (key === "GMAPS_API_KEY") {
return gmaps_api_key;
} else if (key === "ENABLE_SINGLEINSTANCE") {
return centralInstanceEnabled;
} else if (key === "DIGIT_FOOTER_BW") {
return footerBWLogoURL;
} else if (key === "DIGIT_FOOTER") {
return footerLogoURL;
} else if (key === "DIGIT_HOME_URL") {
return digitHomeURL;
} else if (key === "S3BUCKET") {
return assetS3Bucket;
} else if (key === "CONTEXT_PATH") {
return contextPath;
} else if (key === "UICONFIG_MODULENAME") {
return configModuleName;
} else if (key === "LOCALE_REGION") {
return localeRegion;
} else if (key === "LOCALE_DEFAULT") {
return localeDefault;
} else if (key === "HRMS_CONTEXT_PATH") {
return hrmsContext;
} else if (key === "CALCULATION_PAGE_ASSETS") {
return calculationPageAssets;
}
else if (key === "PROJECT_CONTEXT_PATH") {
return projectContext;
}
else if (key === "PROJECT_SERVICE_PATH") {
return projectContext;
}
else if(key == "HIERARCHY_TYPE"){
return hierarchyType;
}
else if(key == "INDIVIDUAL_CONTEXT_PATH"){
return individualContext;
}
else if(key == "ATTENDANCE_CONTEXT_PATH"){
return attendanceContext;
}
else if(key == "MUSTER_ROLL_CONTEXT_PATH"){
return musterRollContext;
}
else if(key == "EXPENSE_CONTEXT_PATH"){
return expenseContext;
}
else if(key == "EXPENSE_CALCULATOR_CONTEXT_PATH"){
return expenseCalculatorContext;
} else if (key === "MDMS_CONTEXT_PATH") {
return mdmsContext;
} else if (key === "MDMS_V2_CONTEXT_PATH") {
return mdmsContext;
} else if (key === "MDMS_V1_CONTEXT_PATH") {
return mdmsContext;
}
};
return {
getConfig,
};
})();
</script>
Comment on lines +23 to +111
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Improve configuration structure and consistency.

The inline configuration script has several areas for improvement:

  1. Inconsistent equality operators: Mix of === and == (line 82)
  2. Missing return statement: The function doesn't return anything for unmatched keys
  3. Formatting inconsistencies: Some lines have trailing spaces and inconsistent indentation

Apply this diff to fix the issues:

-      else if(key == "INDIVIDUAL_CONTEXT_PATH"){
+      else if (key === "INDIVIDUAL_CONTEXT_PATH") {
        return individualContext;
      }
-      else if(key == "ATTENDANCE_CONTEXT_PATH"){
+      else if (key === "ATTENDANCE_CONTEXT_PATH") {
        return attendanceContext;
      }
-      else if(key == "MUSTER_ROLL_CONTEXT_PATH"){
+      else if (key === "MUSTER_ROLL_CONTEXT_PATH") {
        return musterRollContext;
      }
-      else if(key == "EXPENSE_CONTEXT_PATH"){
+      else if (key === "EXPENSE_CONTEXT_PATH") {
        return expenseContext;
      }
-      else if(key == "EXPENSE_CALCULATOR_CONTEXT_PATH"){
+      else if (key === "EXPENSE_CALCULATOR_CONTEXT_PATH") {
        return expenseCalculatorContext;
-      }     else if (key === "MDMS_CONTEXT_PATH") {
+      } else if (key === "MDMS_CONTEXT_PATH") {
        return mdmsContext;
      } else if (key === "MDMS_V2_CONTEXT_PATH") {
        return mdmsContext;
      } else if (key === "MDMS_V1_CONTEXT_PATH") {
        return mdmsContext;
-      } 
+      } else {
+        return null; // or undefined, depending on expected behavior
+      }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<script>
var globalConfigs = (function () {
var contextPath = "payments-ui";
var projectContext = "project";
var individualContext = "individual";
var attendanceContext = "attendance";
var musterRollContext = "health-muster-roll";
var expenseContext = "health-expense";
var expenseCalculatorContext = "health-expense-calculator";
var stateTenantId = "cg";
var gmaps_api_key = "AIzaSyAASfCFja6YxwDzEAzhHFc8B-17TNTCV0g";
var configModuleName = "commonUiConfig";
var centralInstanceEnabled = false;
var localeRegion = "CG";
var localeDefault = "en";
var mdmsContext = "mdms-v2";
var hrmsContext = "egov-hrms";
var hierarchyType = "ADMIN";
var footerBWLogoURL =
"https://unified-dev.digit.org/egov-dev-assets/digit-footer-bw.png";
var footerLogoURL =
"https://unified-dev.digit.org/egov-dev-assets/digit-footer.png";
var digitHomeURL = "https://www.digit.org/";
var assetS3Bucket = "egov-dev-assets";
var calculationPageAssets = "https://egov-health-dev-assets.s3.ap-south-1.amazonaws.com/calculation-page-assets/"
var getConfig = function (key) {
if (key === "STATE_LEVEL_TENANT_ID") {
return stateTenantId;
} else if (key === "GMAPS_API_KEY") {
return gmaps_api_key;
} else if (key === "ENABLE_SINGLEINSTANCE") {
return centralInstanceEnabled;
} else if (key === "DIGIT_FOOTER_BW") {
return footerBWLogoURL;
} else if (key === "DIGIT_FOOTER") {
return footerLogoURL;
} else if (key === "DIGIT_HOME_URL") {
return digitHomeURL;
} else if (key === "S3BUCKET") {
return assetS3Bucket;
} else if (key === "CONTEXT_PATH") {
return contextPath;
} else if (key === "UICONFIG_MODULENAME") {
return configModuleName;
} else if (key === "LOCALE_REGION") {
return localeRegion;
} else if (key === "LOCALE_DEFAULT") {
return localeDefault;
} else if (key === "HRMS_CONTEXT_PATH") {
return hrmsContext;
} else if (key === "CALCULATION_PAGE_ASSETS") {
return calculationPageAssets;
}
else if (key === "PROJECT_CONTEXT_PATH") {
return projectContext;
}
else if (key === "PROJECT_SERVICE_PATH") {
return projectContext;
}
else if(key == "HIERARCHY_TYPE"){
return hierarchyType;
}
else if(key == "INDIVIDUAL_CONTEXT_PATH"){
return individualContext;
}
else if(key == "ATTENDANCE_CONTEXT_PATH"){
return attendanceContext;
}
else if(key == "MUSTER_ROLL_CONTEXT_PATH"){
return musterRollContext;
}
else if(key == "EXPENSE_CONTEXT_PATH"){
return expenseContext;
}
else if(key == "EXPENSE_CALCULATOR_CONTEXT_PATH"){
return expenseCalculatorContext;
} else if (key === "MDMS_CONTEXT_PATH") {
return mdmsContext;
} else if (key === "MDMS_V2_CONTEXT_PATH") {
return mdmsContext;
} else if (key === "MDMS_V1_CONTEXT_PATH") {
return mdmsContext;
}
};
return {
getConfig,
};
})();
</script>
var getConfig = function (key) {
if (key === "STATE_LEVEL_TENANT_ID") {
return stateTenantId;
} else if (key === "GMAPS_API_KEY") {
return gmaps_api_key;
} else if (key === "ENABLE_SINGLEINSTANCE") {
return centralInstanceEnabled;
} else if (key === "DIGIT_FOOTER_BW") {
return footerBWLogoURL;
} else if (key === "DIGIT_FOOTER") {
return footerLogoURL;
} else if (key === "DIGIT_HOME_URL") {
return digitHomeURL;
} else if (key === "S3BUCKET") {
return assetS3Bucket;
} else if (key === "CONTEXT_PATH") {
return contextPath;
} else if (key === "UICONFIG_MODULENAME") {
return configModuleName;
} else if (key === "LOCALE_REGION") {
return localeRegion;
} else if (key === "LOCALE_DEFAULT") {
return localeDefault;
} else if (key === "HRMS_CONTEXT_PATH") {
return hrmsContext;
} else if (key === "CALCULATION_PAGE_ASSETS") {
return calculationPageAssets;
} else if (key === "PROJECT_CONTEXT_PATH") {
return projectContext;
} else if (key === "PROJECT_SERVICE_PATH") {
return projectContext;
} else if (key === "HIERARCHY_TYPE") {
return hierarchyType;
} else if (key === "INDIVIDUAL_CONTEXT_PATH") {
return individualContext;
} else if (key === "ATTENDANCE_CONTEXT_PATH") {
return attendanceContext;
} else if (key === "MUSTER_ROLL_CONTEXT_PATH") {
return musterRollContext;
} else if (key === "EXPENSE_CONTEXT_PATH") {
return expenseContext;
} else if (key === "EXPENSE_CALCULATOR_CONTEXT_PATH") {
return expenseCalculatorContext;
} else if (key === "MDMS_CONTEXT_PATH") {
return mdmsContext;
} else if (key === "MDMS_V2_CONTEXT_PATH") {
return mdmsContext;
} else if (key === "MDMS_V1_CONTEXT_PATH") {
return mdmsContext;
} else {
return null; // or undefined, depending on expected behavior
}
};
🤖 Prompt for AI Agents
In health/micro-ui/web/micro-ui-internals/example/public/index.html between
lines 23 and 111, fix the inline configuration script by replacing all instances
of loose equality (==) with strict equality (===) for consistency, add a default
return statement (such as returning null or undefined) at the end of the
getConfig function to handle unmatched keys, and clean up formatting by removing
trailing spaces and ensuring consistent indentation throughout the script.

</head>

<body>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,12 @@ module.exports = function (app) {
"/health-expense/bill/v1/_search",
"/health-expense-calculator/v1/_calculate",
"/filestore/v1/files/id",
"/attendance/v1/_search"
"/attendance/v1/_search",
"/health-expense/bill/v1/_update",
"/health-expense/v1/bill/details/status/_update",
"/health-expense/v1/task/_status",
"/health-expense/v1/bill/_verify",
"/health-expense/v1/payment/_transfer"
// "/health-muster-roll/v1/_create",
// "/health-muster-roll/v1/_estimate"
].forEach((location) => app.use(location, createProxy));
Expand Down
Loading