Scale IBF on shell:resize after async ZoomChanged #3329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adapts ImageBasedFrame scaling to be triggered when it's Shell recieves a resize event after ZoomChanged event on its wrapped control. This will correct an inconsistent refresh when the ZoomChanged events are handled asynchronously.
HeikoKlare
approved these changes
Sep 26, 2025
There was a problem hiding this comment.
Looks good an works fine with eclipse-platform/eclipse.platform.swt#2520
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts ImageBasedFrame scaling to be triggered when it's Shell receives a resize event after ZoomChanged event on its wrapped control. This will correct an inconsistent refresh when the ZoomChanged events are handled asynchronously.
This PR does not fix an existing visible issue, but will prevent an issue, after the asynchronous handling in eclipse-platform/eclipse.platform.swt#2520 is merged.