-
Notifications
You must be signed in to change notification settings - Fork 226
Clean Code for bundles/org.eclipse.jface.text #3293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eclipse-platform-bot
wants to merge
1
commit into
master
Choose a base branch
from
clean-code/bundles/org.eclipse.jface.text
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Clean Code for bundles/org.eclipse.jface.text #3293
eclipse-platform-bot
wants to merge
1
commit into
master
from
clean-code/bundles/org.eclipse.jface.text
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41d9bee
to
03683f1
Compare
akurtakov
reviewed
Sep 25, 2025
...clipse.jface.text/src/org/eclipse/jface/text/contentassist/AsyncCompletionProposalPopup.java
Outdated
Show resolved
Hide resolved
03683f1
to
ab6b8d6
Compare
@laeubi This is simply non reviewable (even according to Github UI). Is there a way to run smaller set of changes for this bundle or should it be done manually so we got a PR that can actually be reviewed? |
ab6b8d6
to
88bee99
Compare
88bee99
to
d1391ba
Compare
akurtakov
reviewed
Sep 27, 2025
...clipse.jface.text/src/org/eclipse/jface/text/contentassist/AsyncCompletionProposalPopup.java
Outdated
Show resolved
Hide resolved
7ea3aa8
to
3bf0879
Compare
@akurtakov I think most of these changes are "Convert control statement bodies to block". I run this clean-up manually and push it in smaller batches so that this becomes reviewable. |
2b521f0
to
3373e3f
Compare
3373e3f
to
2daca21
Compare
2daca21
to
1defe6a
Compare
1defe6a
to
5a9b96f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following cleanups were applied: