-
Notifications
You must be signed in to change notification settings - Fork 182
Extend ImageLoader to be able to load images at a given height and width #2509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend ImageLoader to be able to load images at a given height and width #2509
Conversation
Test Results 118 files ±0 118 suites ±0 10m 21s ⏱️ +5s For more details on these failures, see this check. Results for commit 920ecbb. ± Comparison against base commit 810cbcc. ♻️ This comment has been updated with latest results. |
8cefbcf
to
4283b70
Compare
4283b70
to
ecd82db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this change looks good to me. I am just wondering if the term "target" in all the methods/variables is appropriate and helpful. In the zoom case, we have the distinction between fileZoom
and targetZoom
as we need to know which zoom an image represents. But for the size case there is no such distinction, as you just need to tell the size you want to have. So I think we should maybe remove all the "target" and just call everything width
, height
, loadBySize
etc.
ecd82db
to
fb8859f
Compare
Done |
Extend ImageLoader to be able to load images at a given height and width in addition to the current behaviour of only being able to load images at a target zoom. This is required to load images in SVG format at custom height and width. Co-authored-by: Michael Bangas <michael.bangas@vector.com>
fb8859f
to
920ecbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed a typo in the commit message and added @Michael5601 as co author as the code for the initial prototype was developed by him: Michael5601#2
Thank you for finishing the prototype. It's very nice to see all the work getting merged now :). |
Extend ImageLoader to able to load images at a given target height and width in addition to the current behavior of only being able to load images at a target zoom. This is required to load images in svg format at custom height and width.
The extensions added in this change is used in #2526 That PR also contains snippets through which these changes are tested.
This depends on #2514, Only last commit is relevant for this PR