Enable if pattern simplification and disable requireNonNull simplifications of CFG simplifier #22838
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The simplifyUnresolvedRequireNonNull and simplifyResolvedRequireNonNull transformations of CFG Simplifier have never been fully tested. This change disables those transformations so that other transformations performed by CFG Simplifier that are known to be safe can be reenabled. The intention is that the "Requires non-null" transformations will be reenabled once they have been more thoroughly tested and any necessary bug fixes have been applied. Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
The J9::CFGSimplifier::simplifyIfPatterns method of CFG Simplification had been disabled by default due to bugs in the upstream implementation of OMR::CFGSimplifier::simplifyIfPatterns as well as bugs exposed by those transformations. The problematic transformations in OMR have been temporarily disabled, allowing J9's simplifyIfPatterns to be enabled again by default. Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
hzongaro
added
comp:jit
depends:omr
|
Marking this as a draft pull request as it depends on OMR pull request eclipse-omr/omr#8005 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
J9::CFGSimplifier::simplifyIfPatternsmethod of CFG Simplification had been disabled by default due to bugs in the upstream implementation ofOMR::CFGSimplifier::simplifyIfPatternsas well as bugs exposed by those transformations. The problematic transformations in OMR have been temporarily disabled by OMR Pull Request 8005, allowing J9'ssimplifyIfPatternsto be enabled again by default.Also, the
simplifyUnresolvedRequireNonNullandsimplifyResolvedRequireNonNulltransformations of CFG Simplifier have never been fully tested. This change disables those transformations so that other transformations performed by CFG Simplifier that are known to be safe can be re-enabled. The intention is that the "Requires non-null" transformations will themselves be re-eenabled once they have been more thoroughly tested and any necessary bug fixes have been applied.