fix: refactor the pagination prefix and token processing #1476
+24
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shashank1116
changed the title
|
The playlist transfer is tested using the local demo server. Below are the screenshots : Logs from demo -server after the playlist transfer : Youtube music library of the two accounts after transfer: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encapsulate pageTokenPrefix and paginationToken within a unified PageToken class or utility functions to simplify and generalize pagination logic.
Issue : The logic to validate and extract the pageToken from the request is not standardized and has repetition for every case which makes it error prone.
The change was already done for exporting release.
This change adds generic methods to the StringPaginationToken class and refactors the export playlist method.