Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Oct 24, 2025

Note

This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

Updated Dependencies

  • From 10.0.0-beta.25519.102 to 10.0.0-beta.25523.113
    • Microsoft.DotNet.Arcade.Sdk
    • Microsoft.DotNet.Build.Tasks.Templating
    • Microsoft.DotNet.Helix.Sdk
  • From 10.0.0 to 10.0.0
    • Microsoft.Extensions.Caching.Memory
    • Microsoft.Extensions.Configuration
    • Microsoft.Extensions.Configuration.Abstractions
    • Microsoft.Extensions.Configuration.EnvironmentVariables
    • Microsoft.Extensions.Configuration.Json
    • Microsoft.Extensions.DependencyInjection
    • Microsoft.Extensions.DependencyModel
    • Microsoft.Extensions.Logging
    • Microsoft.NETCore.App.Ref
    • System.Formats.Asn1
    • System.Runtime.Caching
    • System.Text.Encodings.Web
    • System.Text.Json
  • From 10.0.0-rtm.25519.102 to 10.0.0-rtm.25523.113
    • Microsoft.Extensions.HostFactoryResolver.Sources
    • Microsoft.NETCore.Platforms

Associated changes in source repos

Updated Dependencies:
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk (Version 10.0.0-beta.25519.102 -> 10.0.0-beta.25523.108)
Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Logging, Microsoft.NETCore.App.Ref, System.Formats.Asn1, System.Runtime.Caching, System.Text.Encodings.Web, System.Text.Json (Version 10.0.0 -> 10.0.0)
Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.NETCore.Platforms (Version 10.0.0-rtm.25519.102 -> 10.0.0-rtm.25523.108)
@AndriySvyryd
Copy link
Member

Since the change to stable versioning Helix is failing with

C:\Users\cloudtest\.nuget\packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25523.108\tools\dotnet-cli\DotNetCli.targets(40,5): error : Unable to find dotnet cli runtime version 10.0.0 from any of the specified feeds. [D:\a\_work\1\s\eng\helix.proj]

@ViktorHofer @mmitche Have you seen this?

Updated Dependencies:
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk (Version 10.0.0-beta.25523.108 -> 10.0.0-beta.25523.113)
Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Logging, Microsoft.NETCore.App.Ref, System.Formats.Asn1, System.Runtime.Caching, System.Text.Encodings.Web, System.Text.Json (Version 10.0.0 -> 10.0.0)
Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.NETCore.Platforms (Version 10.0.0-rtm.25523.108 -> 10.0.0-rtm.25523.113)
@ViktorHofer
Copy link
Member

ViktorHofer commented Oct 28, 2025

This failure is due to this line:

<AdditionalDotNetPackage Include="$(MicrosoftNETCoreAppRefVersion)">

With that you tell helix to restore the runtime package with that specific version which currently is stable. But the task doesn't have access to the isolated feed in which the stable package resides.

image

I think this means that the default URI that it tries to fetch the runtime package from is incorrect. I'm not sure why you need this entry at all.

@SamMonoRT
Copy link
Member

This failure is due to this line:

<AdditionalDotNetPackage Include="$(MicrosoftNETCoreAppRefVersion)">

This was introduced well back in b2dd10e#diff-de3ca0ca5220bb3b322733f4e43e179b906cb9a96eefb0c5a04d8adfd31e32e4 --- why would it fail now, and would you know the correct way to fix this?

@ViktorHofer
Copy link
Member

So the SDK that this PR upgrades to has the following bundled NETCoreRuntime version:

image

Helix reads that here: https://github.com/dotnet/arcade/blob/d48732057be73512b3bac9c01eeacd59398c16d5/src/Microsoft.DotNet.Helix/Sdk/tools/dotnet-cli/DotNetCli.props#L10

image

So that's not it.


I see that previous PR already failed in this step and were merged on red:

image

This started happening with #36972

@ViktorHofer
Copy link
Member

So my above statement is correct:

With that you tell helix to restore the runtime package with that specific version which currently is stable. But the task doesn't have access to the isolated feed in which the stable package resides.
I think this means that the default URI that it tries to fetch the runtime package from is incorrect. I'm not sure why you need this entry at all.

cc @mmitche

@mmitche
Copy link
Member

mmitche commented Oct 29, 2025

MicrosoftNetCoreAppRef isn't the right package for this. You want the non-stable version. Microsoft.NETCore.Platforms. The system will find the non-stable directory in storage, find the a productVersion.txt inside and see that the file name is actually supposed to be stable, and then construct the correct URI.

@mmitche
Copy link
Member

mmitche commented Oct 29, 2025

Looking good now.

@SamMonoRT
Copy link
Member

@AndriySvyryd @cincuranet - this looks good to merge now

@dotnet-maestro dotnet-maestro bot merged commit e4bc921 into release/10.0 Oct 29, 2025
13 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-release/10.0-5afe219e-6248-4a7d-b9e3-1395c60e3074 branch October 29, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants