-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[release/10.0] Source code updates from dotnet/dotnet #37022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/10.0] Source code updates from dotnet/dotnet #37022
Conversation
Updated Dependencies: Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk (Version 10.0.0-beta.25519.102 -> 10.0.0-beta.25523.108) Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Logging, Microsoft.NETCore.App.Ref, System.Formats.Asn1, System.Runtime.Caching, System.Text.Encodings.Web, System.Text.Json (Version 10.0.0 -> 10.0.0) Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.NETCore.Platforms (Version 10.0.0-rtm.25519.102 -> 10.0.0-rtm.25523.108)
|
Since the change to stable versioning Helix is failing with @ViktorHofer @mmitche Have you seen this? |
Updated Dependencies: Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk (Version 10.0.0-beta.25523.108 -> 10.0.0-beta.25523.113) Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Logging, Microsoft.NETCore.App.Ref, System.Formats.Asn1, System.Runtime.Caching, System.Text.Encodings.Web, System.Text.Json (Version 10.0.0 -> 10.0.0) Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.NETCore.Platforms (Version 10.0.0-rtm.25523.108 -> 10.0.0-rtm.25523.113)
|
This failure is due to this line: Line 33 in af2d7b8
With that you tell helix to restore the runtime package with that specific version which currently is stable. But the task doesn't have access to the isolated feed in which the stable package resides.
I think this means that the default URI that it tries to fetch the runtime package from is incorrect. I'm not sure why you need this entry at all. |
This was introduced well back in b2dd10e#diff-de3ca0ca5220bb3b322733f4e43e179b906cb9a96eefb0c5a04d8adfd31e32e4 --- why would it fail now, and would you know the correct way to fix this? |
|
So the SDK that this PR upgrades to has the following bundled NETCoreRuntime version: Helix reads that here: https://github.com/dotnet/arcade/blob/d48732057be73512b3bac9c01eeacd59398c16d5/src/Microsoft.DotNet.Helix/Sdk/tools/dotnet-cli/DotNetCli.props#L10
So that's not it. I see that previous PR already failed in this step and were merged on red:
This started happening with #36972 |
|
So my above statement is correct:
cc @mmitche |
|
MicrosoftNetCoreAppRef isn't the right package for this. You want the non-stable version. Microsoft.NETCore.Platforms. The system will find the non-stable directory in storage, find the a productVersion.txt inside and see that the file name is actually supposed to be stable, and then construct the correct URI. |
|
Looking good now. |
|
@AndriySvyryd @cincuranet - this looks good to merge now |



Note
This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Updated Dependencies
Associated changes in source repos