feat(cli): Create new option --dry-run=json
#1640
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… info or log error or eprintln()
NikolaMilosa
approved these changes
Jul 9, 2025
pietrodimarco-dfinity
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the value
jsonis specified to the parameter--dry-run=, any proposals that would otherwise be printed to the console will be printed in JSON format, for ease of parsing.This feature is required for the HostOS rollout.
Additionally, the parameter
--nodes-in-groupis upgraded to use the clap infrastructure to validate its value, and to only accept positive integers (it made no sense to use negative integers).