Skip to content

Conversation

AbhishekA1509
Copy link
Member

Description

This pull request introduces cost visibility support for clusters, particularly with GCP integration, and refactors cluster form handling to accommodate cost module configuration and provider-specific requirements. It adds new props, state management, validation, and UI feedback for cost visibility, including installation status and error handling. The changes also generalize cluster provider handling and update navigation and type definitions for improved clarity and extensibility.

Cost Visibility and Cluster Provider Integration:

  • Added cost visibility module support to cluster forms, including state management for enabling/disabling, API key input, error handling, and GCP-specific validation. UI now reflects installation status and errors for the cost module. (src/Pages/GlobalConfigurations/ClustersAndEnvironments/ClusterForm/ClusterForm.tsx, src/Pages/GlobalConfigurations/ClustersAndEnvironments/ClusterForm/ClusterForm.components.tsx, [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
  • Extended cluster form and edit drawer components to accept and handle new costModuleConfig and clusterProvider props, propagating them through the UI and logic. (src/Pages/GlobalConfigurations/ClustersAndEnvironments/ClusterList.components.tsx, src/Pages/GlobalConfigurations/ClustersAndEnvironments/EditClusterDrawerContent.tsx, [1] [2] [3] [4] [5]

Type and API Refactoring:

  • Updated type definitions to include costModuleConfig and clusterProvider in cluster-related props, improving type safety and extensibility for cluster forms and drawers. (src/Pages/GlobalConfigurations/ClustersAndEnvironments/cluster.type.ts, [1] [2] [3] [4]

Navigation and Component Imports:

  • Registered EditClusterDrawerContent in navigation routes and updated import statements for new cost visibility provider props. (src/components/common/navigation/NavigationRoutes.tsx, [1] [2]

UI and Minor Fixes:

  • Fixed minor UI typo (divder__secondary--horizontal to divider__secondary--horizontal) and improved subtitle rendering in navigation buttons to support React nodes for richer feedback. (src/Pages/GlobalConfigurations/ClustersAndEnvironments/ClusterForm/ClusterForm.tsx, src/Pages/GlobalConfigurations/ClustersAndEnvironments/ClusterForm/ClusterForm.components.tsx, [1] [2] [3]

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Copy link

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@github-actions github-actions bot added the PR:Issue-verification-failed PR:Issue-verification-failed label Sep 25, 2025
Copy link

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

…tching and add EditClusterDrawerMetadataType interface
Copy link

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

Copy link

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

vivek-devtron
vivek-devtron previously approved these changes Sep 29, 2025
Copy link

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

Copy link

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@AbhishekA1509 AbhishekA1509 changed the title feat: cost config chore: cost config Sep 29, 2025
@github-actions github-actions bot added PR:Ready-to-Review PR:Ready-to-Review and removed PR:Issue-verification-failed PR:Issue-verification-failed labels Sep 29, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@AbhishekA1509 AbhishekA1509 merged commit d32ba57 into kubecon-2025 Sep 29, 2025
6 of 8 checks passed
@AbhishekA1509 AbhishekA1509 deleted the feat/cost-config branch September 29, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Ready-to-Review PR:Ready-to-Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants