-
Notifications
You must be signed in to change notification settings - Fork 55
chore: cost config #2936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cost config #2936
Conversation
…tent into NavigationRoutes
…Content, and NavigationRoutes
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
…tching and add EditClusterDrawerMetadataType interface
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
…tadata for metadata fetching
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
…icsEnabled and toggleAppMetrics for better state management
…lusterForm for enhanced state management
…updating related components
fix: cluster form error
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Description
This pull request introduces cost visibility support for clusters, particularly with GCP integration, and refactors cluster form handling to accommodate cost module configuration and provider-specific requirements. It adds new props, state management, validation, and UI feedback for cost visibility, including installation status and error handling. The changes also generalize cluster provider handling and update navigation and type definitions for improved clarity and extensibility.
Cost Visibility and Cluster Provider Integration:
src/Pages/GlobalConfigurations/ClustersAndEnvironments/ClusterForm/ClusterForm.tsx
,src/Pages/GlobalConfigurations/ClustersAndEnvironments/ClusterForm/ClusterForm.components.tsx
, [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]costModuleConfig
andclusterProvider
props, propagating them through the UI and logic. (src/Pages/GlobalConfigurations/ClustersAndEnvironments/ClusterList.components.tsx
,src/Pages/GlobalConfigurations/ClustersAndEnvironments/EditClusterDrawerContent.tsx
, [1] [2] [3] [4] [5]Type and API Refactoring:
costModuleConfig
andclusterProvider
in cluster-related props, improving type safety and extensibility for cluster forms and drawers. (src/Pages/GlobalConfigurations/ClustersAndEnvironments/cluster.type.ts
, [1] [2] [3] [4]Navigation and Component Imports:
EditClusterDrawerContent
in navigation routes and updated import statements for new cost visibility provider props. (src/components/common/navigation/NavigationRoutes.tsx
, [1] [2]UI and Minor Fixes:
divder__secondary--horizontal
todivider__secondary--horizontal
) and improved subtitle rendering in navigation buttons to support React nodes for richer feedback. (src/Pages/GlobalConfigurations/ClustersAndEnvironments/ClusterForm/ClusterForm.tsx
,src/Pages/GlobalConfigurations/ClustersAndEnvironments/ClusterForm/ClusterForm.components.tsx
, [1] [2] [3]Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: