Potential fix for code scanning alert no. 2: Overly permissive regular expression range #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r expression range Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Deploying deriv-utils with
|
| Latest commit: |
cc873ac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6c8be45b.deriv-utils.pages.dev |
| Branch Preview URL: | https://habib-code-scaning-issue-fix.deriv-utils.pages.dev |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Pull Request Test Coverage Report for Build 15182578449Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/deriv-com/deriv-utils/security/code-scanning/2
To fix the issue, we need to replace the overly permissive range
,-;with an explicit list of the intended characters:,,-, and;. This ensures that the regex matches only the desired characters and avoids unintended matches. The corrected regex will explicitly list all allowed characters without relying on ambiguous ranges.The specific change will be made to the
addressStatepattern on line 34. The updated regex will replace,-;with,;-to explicitly include only the intended characters.Suggested fixes powered by Copilot Autofix. Review carefully before merging.