Skip to content

Conversation

TheAngryByrd
Copy link
Collaborator

@TheAngryByrd TheAngryByrd commented Jun 1, 2025

Proposed Changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to FsToolkit.ErrorHandling?
Put an x in the boxes that apply and remove ones that don't apply

  • Project Infrastructure

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

…include Fable.Mocha and Fable.Pyxpecto in test dependencies
- Removed Mocha as a test runner and replaced it with Pyxpecto for JavaScript and Python Fable compilers.
- Updated package.json to reflect the removal of Mocha and adjusted test scripts to use Node directly.
- Added conditional compilation directives to support Pyxpecto across different Fable compilers.
- Cleaned up test files by removing unnecessary Mocha references and ensuring compatibility with Pyxpecto.
- Introduced ignore tests for AsyncResultOption under specific compiler conditions.
@TheAngryByrd TheAngryByrd marked this pull request as ready for review June 1, 2025 19:45
@TheAngryByrd TheAngryByrd requested a review from Copilot June 1, 2025 20:02
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes Paket-related configurations and references across the solution and migrates project dependencies entirely to NuGet and PackageReference. Key changes include:

  • Replacing Paket dependency management files and targets with NuGet and central package management.
  • Updating build and tooling scripts to remove Paket commands and use dotnet tool commands instead.
  • Minor code adjustments including a change in the disposable interface type in IcedTasks.

Reviewed Changes

Copilot reviewed 87 out of 87 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/FsToolkit.ErrorHandling.IcedTasks/CancellableTaskResultBuilderBase.fs Updated disposable type parameters from #IDisposable to #IDisposableNull.
src/FsToolkit.ErrorHandling.AsyncSeq/paket.references Removed Paket references in favor of PackageReference.
src/FsToolkit.ErrorHandling.AsyncSeq/FsToolkit.ErrorHandling.AsyncSeq.fsproj Removed Paket restore targets and updated dependency management.
src/Directory.Build.props Added conditional PackageReference configuration for Microsoft.Bcl.AsyncInterfaces and FSharp.Core.
paket.dependencies Removed Paket dependency file.
package.json Adjusted test commands to use node and added --noCache flags.
build/paket.references, benchmarks/paket.references Removed Paket reference files.
build/build.fsproj Removed Paket restore targets and switched to PackageReference for build tools.
build/build.fs Replaced Paket.push with DotNet.nugetPush and updated test command flags.
benchmarks/benchmarks.fsproj Updated target frameworks and introduced a PackageReference for BenchmarkDotnet.
benchmarks/SeqTests.fs Added missing module import.
Directory.Solution.targets, Directory.Packages.props, Directory.Build.props Updated centralized package management and build configuration.
.vscode/extensions.json, .devcontainer/devcontainer.json, .config/dotnet-tools.json Removed Paket-related recommendations and updated tool versions.
.github/workflows/build.yml, .editorconfig Updated Node versions and removed Paket file style rules.
Comments suppressed due to low confidence (1)

benchmarks/benchmarks.fsproj:32

  • The package reference 'BenchmarkDotnet' appears to have inconsistent casing compared to the official package name 'BenchmarkDotNet'. Consider updating it to ensure consistency.
<PackageReference Include="BenchmarkDotnet"/>

@TheAngryByrd TheAngryByrd merged commit 2cdaff1 into master Jun 1, 2025
26 checks passed
@TheAngryByrd TheAngryByrd changed the title Remove paket Remove paket, Enforce nullness on net9.0, remove mocha Jun 2, 2025
TheAngryByrd added a commit that referenced this pull request Jun 2, 2025
- BREAKING: [Remove Ply and update to FSharp 6](#248) Credits @TheAngryByrd
- BREAKING: [Remove MergeSources (and!) from some implementations like Result](#261)  Credits @TheAngryByrd
- BREAKING: [Merge TaskResult into Core library](#285) Credits @TheAngryByrd
- This means FsToolkit.ErrorHandling.TaskResult is no longer a separate package and will not be updated. It is now part of the core library.
- BREAKING: [Rename retn to singleton](#287) Credits @1eyewonder
- BREAKING: [Rename returnError to error + documentation](#311) Credits @tw0po1nt
- [Use Microsoft.Bcl.AsyncInterfaces in netstandard2.0 (Allows IAsyncDisposable and IAsyncEnumerable)](#250) Credits @TheAngryByrd
- [Build against Net8](#251) Credits @TheAngryByrd
- [Fix Overload Resolution to Align to Computation Expression used](#252) Credits @TheAngryByrd
- [refactor!: Seq.sequenceResultM returns Array instead of seq](#255) Credits @bartelink
- [feat(Seq): sequenceResultA](#255) Credits @bartelink
- [Updated uses of Seq.append](#290) Credits @1eyewonder
- [Add Option.traverseAsync and Option.sequenceAsync](#298 (comment)) Credits @tw0po1nt
- [Add Require and Check helper methods](#295) Credits @PI-Gorbo
- [Add new AsyncOption APIs and document all its other functions; minor fixes to documentation for Option module](#307) Credits @tw0po1nt
- [F# 9 support and nullness](#308) Credits @TheAngryByrd
- [Update IcedTasks 0.11.7](0a4cc7b) Credits @TheAngryByrd
- [Add TaskValidation module](#313) Credits @tw0po1nt
- [feat(Seq.traverse/sequence*)!: Yield arrays](#310) Credits @bartelink
- [Add ParallelAsync CEs](#318) Credits @njlr
- [Add Option.sequenceAsyncResult and Option.traverseAsyncResult](#321) Credits @JayWearsSocks
- [Add traversals/sequences for Task and TaskResult in the Option module](#325) Credits @tw0po1nt
- [Add ok and error helper functions to TaskResultOption and AsyncResultOption modules](#327) Credits @tw0po1nt
- [Add CancellableTaskOption module and CE + tests and documentation](#328) Credits @tw0po1nt
- [Remove paket, Enforce nullness on net9.0, remove mocha](#331) Credits @TheAngryByrd
- [Add TaskValueOption module, operators, and CE + tests and documentation](#329) Credits @tw0po1nt
TheAngryByrd added a commit that referenced this pull request Jun 2, 2025
- BREAKING: [Remove Ply and update to FSharp 6](#248) Credits @TheAngryByrd
- BREAKING: [Remove MergeSources (and!) from some implementations like Result](#261)  Credits @TheAngryByrd
- BREAKING: [Merge TaskResult into Core library](#285) Credits @TheAngryByrd
- This means FsToolkit.ErrorHandling.TaskResult is no longer a separate package and will not be updated. It is now part of the core library.
- BREAKING: [Rename retn to singleton](#287) Credits @1eyewonder
- BREAKING: [Rename returnError to error + documentation](#311) Credits @tw0po1nt
- [Use Microsoft.Bcl.AsyncInterfaces in netstandard2.0 (Allows IAsyncDisposable and IAsyncEnumerable)](#250) Credits @TheAngryByrd
- [Build against Net8](#251) Credits @TheAngryByrd
- [Fix Overload Resolution to Align to Computation Expression used](#252) Credits @TheAngryByrd
- [refactor!: Seq.sequenceResultM returns Array instead of seq](#255) Credits @bartelink
- [feat(Seq): sequenceResultA](#255) Credits @bartelink
- [Updated uses of Seq.append](#290) Credits @1eyewonder
- [Add Option.traverseAsync and Option.sequenceAsync](#298 (comment)) Credits @tw0po1nt
- [Add Require and Check helper methods](#295) Credits @PI-Gorbo
- [Add new AsyncOption APIs and document all its other functions; minor fixes to documentation for Option module](#307) Credits @tw0po1nt
- [F# 9 support and nullness](#308) Credits @TheAngryByrd
- [Update IcedTasks 0.11.7](0a4cc7b) Credits @TheAngryByrd
- [Add TaskValidation module](#313) Credits @tw0po1nt
- [feat(Seq.traverse/sequence*)!: Yield arrays](#310) Credits @bartelink
- [Add ParallelAsync CEs](#318) Credits @njlr
- [Add Option.sequenceAsyncResult and Option.traverseAsyncResult](#321) Credits @JayWearsSocks
- [Add traversals/sequences for Task and TaskResult in the Option module](#325) Credits @tw0po1nt
- [Add ok and error helper functions to TaskResultOption and AsyncResultOption modules](#327) Credits @tw0po1nt
- [Add CancellableTaskOption module and CE + tests and documentation](#328) Credits @tw0po1nt
- [Remove paket, Enforce nullness on net9.0, remove mocha](#331) Credits @TheAngryByrd
- [Add TaskValueOption module, operators, and CE + tests and documentation](#329) Credits @tw0po1nt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant