build: update to Solr 9 (latest), fixes #69

[stefan-korn]

The Issue

• Fixes Update to Solr 9.9 #69

How This PR Solves The Issue

change the build to point to solr:9.9 docker image by default
add
SOLR_MODULES: "extraction,langid,ltr,analysis-extras"
to environment (for Drupal Search API Solr)

Manual Testing Instructions

ddev add-on get https://github.com/ddev/ddev-solr/tarball/refs/pull/70/head
ddev restart

Automated Testing Overview

Release/Deployment Notes

[stasadev]

Thanks for working on this!

[stasadev]

SOLR_MODULES should be configurable, just like SOLR_BASE_IMAGE, and added to the README.md.

[stefan-korn]

Good point. Not exactly sure about syntax for this, would

SOLR_MODULES: ${SOLR_MODULES:-extraction,langid,ltr,analysis-extras}

be adequate to make it configurable, but use the default in case?

What about the hyphen after the colon? And are escaped double quotes needed?

[stasadev]

See example https://github.com/ddev/ddev-opensearch/blob/b5c038ffbcca39c6d963f93935c2955cb9d6a9cc/docker-compose.opensearch.yaml#L14

It should look like:

SOLR_MODULES: ${SOLR_MODULES-extraction,langid,ltr,analysis-extras}

This way you can "unset" it with ddev dotenv set .ddev/.env.solr --solr-modules=

[stasadev]

Or it can be empty by default:

SOLR_MODULES: ${SOLR_MODULES:-}

And then post_install_actions can check if it's Drupal, and run this command:

ddev dotenv set .ddev/.env.solr --solr-modules=extraction,langid,ltr,analysis-extras

[rfay]

I don't know much about solr stability, but would solr:9 be adequate? That's what the tests are testing against. This docker image does have a sliding major tag.

[stefan-korn]

I don't know much about solr stability, but would solr:9 be adequate? That's what the tests are testing against. This docker image does have a sliding major tag.

Yes seems to make great sense, tests are also getting 9.9 and it would not be hardcoded to a specific version. Though I do not know whether they will release any 9.x versions or only 10.x someday.

[stasadev]

Please add SOLR_MODULES to this table.

And move ### Add custom Solr libraries via SOLR_MODULES env variable section before All customization options (use with caution): line.

[stefan-korn]

done, should All customization options (use with caution): have a heading?

[stefan-korn]

Oh just recognizing that Add third party Solr modules and libraries is somewhat outdated regarding Solr 9.8 ... (lib-directives are deprecated)

[stasadev]

done, should All customization options (use with caution): have a heading?

I don't have heading for that in the template https://github.com/ddev/ddev-addon-template/blob/main/README_ADDON.md

[stasadev]

Oh just recognizing that Add third party Solr modules and libraries is somewhat outdated regarding Solr 9.8 ... (lib-directives are deprecated)

I'm not an expert, but if you think the wording can be improved, maybe use something like: "Use this technique if your Solr version is earlier than 9.8"

[stasadev]

Looks good to me, but let's get more approvals.

[rfay]

Thanks for stepping up to this! Great contribution.

Since the modules are so important, please add test coverage for them, thanks.

[rfay]

Please add test coverage for this, thanks!

[stefan-korn]

I am really a noob in terms of tests. But just asked on the high level at first:

I would propose a test that creates a core based on Drupal Search API solr jump start config should succeed with the SOLR_MODULES set and fail with the SOLR_MODULES unset.

Would that be in line with what you are thinking about testing here? Or something completely different?

[rfay]

Tests aren't hard, look at the existing ones and read https://github.com/ddev/ddev-addon-template and links.

[rfay]

I would test first to make sure that the default modules actually get installed in the solr container (ddev exec -s solr ...)

Then test to see that a changed SOLR_MODULES changes what you get.

[kevinquillen]

With the combination of the 0.7.3 release in August and this change, I can now successfully create collections in 9.8.1 and 9.9. Without it, I get errors on startup or with 'upload configset' in Drupal. I did not change my configset (there are some mods to use extra features in 9.6+) but they applied clean and without error, and indexing works.