Don't decrement frame in setStartAt #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xjpro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite possible this is just a confusion on my part but I figured I'd submit a PR for discussion's sake.
It seems setStartAt expects a value indexed from 1, where all other functions (goToAndPlay, goToAndPause, setEndAt) are indexed from 0. No other functions does the minus 1, which seems odd to me. I would expect either all functions to decrement their frame argument or for none of them to.
I believe most people are comfortable with the idea that "frames" are 0-indexed so I would advocate to simply make setStartAt consistent with the other functions.