Skip to content

Conversation

@alef75
Copy link

@alef75 alef75 commented Oct 18, 2025

πŸ€” What's changed?

just add a basic example of python behave in a eclipse pydev project

⚑️ What's your motivation?

🏷️ What kind of change is this?

  • πŸ“– Documentation (improvements without changing code)
  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • πŸ› Bug fix (non-breaking change which fixes a defect)
  • ⚑ New feature (non-breaking change which adds new behaviour)
  • πŸ’₯ Breaking change (incompatible changes to the API)

♻️ Anything particular you want feedback on?

πŸ“‹ Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Copy link

@jenisys jenisys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor issues

@laeubi
Copy link
Contributor

laeubi commented Oct 19, 2025

@jenisys if you review the code you can mark a line and then there is a litte icon "suggest change" when you use this:

  1. it shows a nice diff of what you propose to change
  2. one can use that to directly commit/accept your suggestion

@laeubi
Copy link
Contributor

laeubi commented Oct 26, 2025

@alef75 do you like to address the comments from @jenisys or should we merge this regardless?

@alef75
Copy link
Author

alef75 commented Oct 27, 2025

There are something I should do here?

@laeubi
Copy link
Contributor

laeubi commented Oct 27, 2025

@alef75 you should look at the comments from @jenisys and then have to decide:

  1. Sound is reasonable and you are fine with it? The just apply the change and push it here!
  2. You disagree or need further clarification? Maybe you leave a comment and discuss the proposal further then go to step 1
  3. As these are not critical you might state that this is all you can offer and we decide to merge it as is and hope someone else later picks up this and improve on that.

@alef75
Copy link
Author

alef75 commented Oct 27, 2025

I've just replied to @jenisys , I agree with both suggestion!

what I need to do?
do I need to apply the suggestion on my fork/branch and then simply commit and push on my fork/branch?

@laeubi
Copy link
Contributor

laeubi commented Oct 27, 2025

Yes just change your fork/branch, commit the changes and push them here!

Alessandro Fardin added 2 commits October 27, 2025 15:14
REASON:
* format appends to a list of formatters from config-file and command-line (you cannot easily override it)
* If you use behave -f plain you override the formatter but still get an pretty.output file because you specified no outfiles
* ALTERNATIVE: pretty is already the default formatter if you do not specify one. Therefore, you can remove it from the config-file with the same effect.
@laeubi laeubi requested a review from jenisys October 27, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants