Skip to content

Conversation

@kdeldycke
Copy link
Contributor

@kdeldycke kdeldycke commented Oct 22, 2025

Fix: #3

Given the big changes, I couldn't help but try to update things left and right:

  • Bump minimal Python to 3.10 (to align it with mdformat 1.0.0 owns requirement)
  • Add tests on Python 3.12, 3.13 and 3.14
  • Remove tests on Python 3.7, 3.8 and 3.9
  • Bump pytest >= 8.4.0 (first version to support Python 3.14)
  • Bump all GitHub workflow actions
  • Update all pre-commit hooks dependencies to their latest release

Sorry if this PR feels a bit bigger in scope than simply fixing mdformat 1.0.0 compatibility. So please tell me if some changes are too aggressive in which case I'll be happy to scale down my propositions.

@kdeldycke
Copy link
Contributor Author

@csala, can you validate the workflow so we can check the result of this PR on the CI?

@csala
Copy link
Owner

csala commented Oct 23, 2025

Thanks for the PR @kdeldycke !
I would indeed scale down some of it 😅

Could we make it only about the version bumpings and keep the other changes for later?

I would say that this would be fine:

  • Bump mdformat dependency to ~=1.0.0
  • Bump minimal Python to 3.10 (to align it with mdformat 1.0.0 owns requirement)
  • Add tests on Python 3.12, 3.13 and 3.14
  • Remove tests on Python 3.7, 3.8 and 3.9
  • Bump all GitHub workflow actions

But this I would separate:

  • Format changes in github workflows and pyproject
  • Typing changes (happy to discuss the need for those in a separate issue!)
  • Bumping plugin version (I prefer to this in a single commit strictly pre-release)

@kdeldycke
Copy link
Contributor Author

Thanks for the PR @kdeldycke ! I would indeed scale down some of it 😅

Aha yeah sure! I'll split that PR and reduce its scope.

Could we make it only about the version bumpings and keep the other changes for later?

I would say that this would be fine:

  • Bump mdformat dependency to ~=1.0.0
  • Bump minimal Python to 3.10 (to align it with mdformat 1.0.0 owns requirement)
  • Add tests on Python 3.12, 3.13 and 3.14
  • Remove tests on Python 3.7, 3.8 and 3.9
  • Bump all GitHub workflow actions

Oh perfect, thanks for detailing your requirements. I'll made the changes and ping you here once it is ready.

@kdeldycke
Copy link
Contributor Author

I just reduced the diff and restricted the changes according your choices. I also squashed everything.

You can now start the workflow to check everything OK before merging it upstream.

@kdeldycke kdeldycke force-pushed the fix-mdformat-1.0.0 branch 2 times, most recently from 19b9e95 to d5dde39 Compare October 23, 2025 14:35
Copy link

@KyleKing KyleKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both! I look forward to getting the mdformat dependency issues sorted out!

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (6a1ef11) to head (00ff511).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           11        11           
=========================================
  Hits            11        11           
Flag Coverage Δ
pytests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kdeldycke
Copy link
Contributor Author

Hmmm pre-commit-hooks tests are failing. It looks like this PR needs #7, but looking at the error messages at #7, it looks like it needs this one.

So both #4 and #7 are mutually requiring each others! 😅

@csala
Copy link
Owner

csala commented Oct 27, 2025

So both #4 and #7 are mutually requiring each others! 😅

This is so silly, but it seems you are right. Alright, let me just merge the other one into this one, and then we should be good.

@csala
Copy link
Owner

csala commented Oct 27, 2025

Alright, let me just merge the other one into this one

No luck, I can't select this branch as target for #7.

Do you mind adding the changes from #7 here @kdeldycke ?

@kdeldycke
Copy link
Contributor Author

Do you mind adding the changes from #7 here @kdeldycke ?

OK give me a couple of minutes to do it.

@kdeldycke
Copy link
Contributor Author

Done. @csala, can you re-run the workflows to check everything's right?

@csala
Copy link
Owner

csala commented Oct 27, 2025

Thanks for the patience with all the back and forth @kdeldycke !
Merging this now

@csala csala merged commit bdca1e6 into csala:master Oct 27, 2025
13 checks passed
@kdeldycke
Copy link
Contributor Author

All tests are passing! Thanks @csala for the merge!

@kdeldycke kdeldycke deleted the fix-mdformat-1.0.0 branch October 27, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uncap mdformat < 0.8.0 requirement

4 participants