Skip to content

Conversation

@crazywhalecc
Copy link
Owner

What does this PR do?

Fix #841

Windows support seems a little complicated. The official php group is maintaining winlibs/net-snmp. Haven't tried yet.

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

# Conflicts:
#	src/globals/test-extensions.php
@crazywhalecc
Copy link
Owner Author

@henderkes Do you think it's necessary that we publish gnu-docker and alpine-docker to ghcr.io for reducing build time, at present?

@henderkes
Copy link
Collaborator

It would certainly help our CI. But I don't think it's necessary to save 2-3 minutes.


# - name: Setup tmate session
# if: ${{ failure() }}
# if: ${{ failure() && matrix.os == 'ubuntu-22.04-arm' && matrix.php == '8.1' }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# if: ${{ failure() && matrix.os == 'ubuntu-22.04-arm' && matrix.php == '8.1' }}
# if: ${{ failure() }}

'bzip2', 'cmake', 'patch',
'xz', 'libtoolize', 'which',
'patchelf',
'patchelf', 'file',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

snmp扩展需求

3 participants