Skip to content

Added tutorial for flight routes visualisation app on streamlit #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Mar 28, 2025
Merged

Added tutorial for flight routes visualisation app on streamlit #48

merged 29 commits into from
Mar 28, 2025

Conversation

@VirajAgarwal1
Copy link
Contributor

No description provided.

@VirajAgarwal1 VirajAgarwal1 self-assigned this Feb 24, 2025
@VirajAgarwal1 VirajAgarwal1 marked this pull request as ready for review February 24, 2025 07:28
@VirajAgarwal1 VirajAgarwal1 requested a review from a team as a code owner February 24, 2025 07:28
nithishr
nithishr requested changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@nithishr nithishr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please switch the demo app to the visualization one. The current one is just for documentation.

nithishr
nithishr requested changes Feb 26, 2025
View reviewed changes
capemox and others added 11 commits February 27, 2025 10:53
@lokeshgoel177
Copy link
Contributor

Please rename the file from Readme.md to something more tutorial specific

lokeshgoel177
lokeshgoel177 reviewed Mar 13, 2025
View reviewed changes
Copy link
Contributor

@lokeshgoel177 lokeshgoel177 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Small Changes here and there and it's good to go

abhiraj2 and others added 5 commits March 17, 2025 09:49
@abhiraj2 @VirajAgarwal1
Added C++ QuickStart Tutorial (#45)
a90177b 
* Added C++ QuickStart Tutorial

* changed search to fts in technologies

* changed repetitive sections and removed unnecessary sections

* refactored for current code

* changed data model section
@actions-user @VirajAgarwal1
Generated markdown tutorials from Jupyter Notebooks
98c8a25 
Generated from: couchbase-examples/vector-search-cookbook
@actions-user @VirajAgarwal1
Generated markdown tutorials from Jupyter Notebooks
1197f96 
Generated from: couchbase-examples/vector-search-cookbook
@actions-user @VirajAgarwal1
Generated markdown tutorials from Jupyter Notebooks
1a02427 
Generated from: couchbase-examples/vector-search-cookbook
@VirajAgarwal1
changes requested by Lokesh
fe16765
@teetangh
Copy link
Contributor

@VirajAgarwal1, you can resolve conversation once the change is fixed.

@lokeshgoel177
Copy link
Contributor

image What are these changes?

@VirajAgarwal1
Copy link
Contributor Author

image What are these changes?

These are the changes made by other members on the main branch. I just updated my branch with the main uing the command git pull origin main. Should I revert this?

@VirajAgarwal1 VirajAgarwal1 changed the title Update README.md Added tutorial for flight routes visualisation app on streamlit Mar 19, 2025
@nithishr
Copy link
Contributor

@VirajAgarwal1 You would need to merge main into your branch after pulling from it.

@VirajAgarwal1
Copy link
Contributor Author

@VirajAgarwal1 You would need to merge main into your branch after pulling from it.

Oh, so I should merge main branch whenever I pull form it. This will help with, looking at changes in a PR. I understand it now. Thank you for pointing this out @nithishr .

Although, I merged the main branch now. I don't think it helps much in undertand the files changed in this PR much... Should I use git revert to try and make it more understandable? though, I think adding more commits here might just make the problem worse...

nithishr
nithishr reviewed Mar 24, 2025
View reviewed changes
@nithishr
Copy link
Contributor

Although, I merged the main branch now. I don't think it helps much in undertand the files changed in this PR much... Should I use git revert to try and make it more understandable? though, I think adding more commits here might just make the problem worse...

I see a clear change in the PR now without changes from other branches. Another option to make the work linear is to use the rebase workflow. From a practical perspective, it will be similar in the output.
We will Squash & Merge this PR so that we will get only a single commit in the main branch with all the changes.

@VirajAgarwal1 VirajAgarwal1 mentioned this pull request Mar 26, 2025
Merged
@VirajAgarwal1 VirajAgarwal1 merged commit bc9e089 into main Mar 28, 2025
4 checks passed
@VirajAgarwal1 VirajAgarwal1 deleted the updated-tutorial-for-streamlit branch March 28, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nithishr nithishr nithishr approved these changes

@shivay-couchbase shivay-couchbase shivay-couchbase left review comments

+1 more reviewer

@lokeshgoel177 lokeshgoel177 lokeshgoel177 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@VirajAgarwal1 VirajAgarwal1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@VirajAgarwal1 @lokeshgoel177 @teetangh @nithishr @shivay-couchbase @capemox @actions-user @abhiraj2