Skip to content

Conversation

dhdaines
Copy link
Contributor

This is like a year and a half overdue, sorry about that @TheMariday ... especially if the fix really is this simple ...

@dhdaines dhdaines added this to the 5.1.0 milestone Aug 20, 2025
@dhdaines
Copy link
Contributor Author

Copy link

@TheMariday TheMariday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix the fetch content issue! Only thing to mention in my findings is that ps will only be able to find the models after the install step which I think is intended functionality. My only wondering is if the POCKETSPHINX_PATH environment variable could be set to the build directory prior to the install step to allow applications to find the models directly after build. I have not tested this however!

@dhdaines
Copy link
Contributor Author

dhdaines commented Sep 6, 2025

This should fix the fetch content issue! Only thing to mention in my findings is that ps will only be able to find the models after the install step which I think is intended functionality. My only wondering is if the POCKETSPHINX_PATH environment variable could be set to the build directory prior to the install step to allow applications to find the models directly after build. I have not tested this however!

(back from vacation) that does seem like a good idea - is the FetchContent use case generally used to build things and run them from the build directory? In general I don't like requiring people to "install" things if not necessary...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants